This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Add Missing System Registers
ClosedPublic

Authored by lenary on Nov 23 2022, 1:52 AM.

Details

Summary

The following system registers have been missing upstream:

  • ID_DFR1_EL1
  • AMCG1IDR_EL0 (present when FEAT_AMUv1p1 implemented - optional from v8.6-a)
  • HAFGRTR_EL2 (present when FEAT_AMUv1 and FEAT_FGT are implemented)

With regards to HAFGRTR_EL2, this is only present when you have both
extensions. As FEAT_FGT is part of a later architecture, we group it
with those registers. In all honesty, this is a good example of the
kinds of place where just enabling all system registers all the time
would be easiest.

Diff Detail

Event Timeline

lenary created this revision.Nov 23 2022, 1:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 23 2022, 1:52 AM
lenary requested review of this revision.Nov 23 2022, 1:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 23 2022, 1:52 AM
This revision is now accepted and ready to land.Nov 23 2022, 2:07 AM
This revision was landed with ongoing or failed builds.Nov 24 2022, 9:48 AM
This revision was automatically updated to reflect the committed changes.