This is an archive of the discontinued LLVM Phabricator instance.

Differential D138537

GlobalIFunc: Fix verifier asserting on unhandled ConstantExpr
AbandonedPublic

Authored by arsenm on Nov 22 2022, 7:00 PM.

Details

Reviewers
MaskRay
ibookstein
dexonsmith
tejohnson

Diff Detail

Unit TestsFailed

TimeTest
60,050 msx64 debian > libFuzzer.libFuzzer::fuzzer-leak.test
60,050 msx64 debian > libFuzzer.libFuzzer::minimize_crash.test
60,050 msx64 debian > libFuzzer.libFuzzer::value-profile-load.test

Revision Contents

PathSize
llvm/
lib/
IR/
2 lines
test/
Assembler/
12 lines

Diff 477369

llvm/lib/IR/Globals.cpp

Show First 20 Lines • Show All 584 Lines • ▼ Show 20 Lines
} }
void GlobalIFunc::eraseFromParent() { void GlobalIFunc::eraseFromParent() {
getParent()->getIFuncList().erase(getIterator()); getParent()->getIFuncList().erase(getIterator());
} }
const Function *GlobalIFunc::getResolverFunction() const { const Function *GlobalIFunc::getResolverFunction() const {
DenseSet<const GlobalAlias *> Aliases; DenseSet<const GlobalAlias *> Aliases;
return dyn_cast<Function>( return dyn_cast_or_null<Function>(
findBaseObject(getResolver(), Aliases, [](const GlobalValue &) {})); findBaseObject(getResolver(), Aliases, [](const GlobalValue &) {}));
} }
void GlobalIFunc::applyAlongResolverPath( void GlobalIFunc::applyAlongResolverPath(
function_ref<void(const GlobalValue &)> Op) const { function_ref<void(const GlobalValue &)> Op) const {
DenseSet<const GlobalAlias *> Aliases; DenseSet<const GlobalAlias *> Aliases;
findBaseObject(getResolver(), Aliases, Op); findBaseObject(getResolver(), Aliases, Op);
} }

llvm/test/Assembler/ifunc-unhandled-constantexpr.ll

  • This file was added.
; RUN: not llvm-as < %s 2>&1 | FileCheck %s
; Make sure nothing asserts on an unhandled constantexpr for the
; resolver.
; CHECK: IFunc must have a Function resolver
; CHECK-NEXT: ptr @ifunc_shl
@ifunc_shl = ifunc void (), ptr inttoptr (i64 shl (i64 ptrtoint (ptr @resolver to i64), i64 4) to ptr)
define ptr @resolver() {
ret ptr null
}