Page MenuHomePhabricator

[Debugify] Strip llvm.mir.debugify metadata
ClosedPublic

Authored by asi-sc on Nov 21 2022, 4:35 AM.

Details

Summary

We don't strip llvm.mir.debugify metadata in llvm::stripDebugifyMetadata. This
may lead to incorrect number of lines and variables in the metadata when we run
debugify twice, e.g. -run-pass=mir-debugify,...,mir-strip-debug,...,mir-debugify.

Diff Detail

Event Timeline

asi-sc created this revision.Nov 21 2022, 4:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 21 2022, 4:35 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
asi-sc requested review of this revision.Nov 21 2022, 4:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 21 2022, 4:35 AM

LGTM (Seems we never directly run debugify twice before)

xiangzhangllvm accepted this revision.Nov 21 2022, 5:39 PM

Let me accept it first, pls wait a little days to see if other reviewers has different opinions

This revision is now accepted and ready to land.Nov 21 2022, 5:39 PM
This revision was landed with ongoing or failed builds.Nov 24 2022, 1:28 AM
This revision was automatically updated to reflect the committed changes.