This is an archive of the discontinued LLVM Phabricator instance.

Differential D138306

[bolt] Pass %cflags in test/X86/is-strip.s
ClosedPublic

Authored by thakis on Nov 18 2022, 8:36 AM.

Details

Reviewers
Amir
rafauler
maksfb
Commits
rG685f671e1d00: [bolt] Pass %cflags in test/X86/is-strip.s
Summary

Without this, clang builds a binary for macOS on a macOS host, and
then the linker complains that it doesn't know the -q flag.

Diff Detail

Event Timeline

thakis created this revision.Nov 18 2022, 8:36 AM
Herald added a reviewer: rafauler. · View Herald TranscriptNov 18 2022, 8:36 AM
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: treapster, ayermolo. · View Herald Transcript
thakis requested review of this revision.Nov 18 2022, 8:36 AM
Herald added a subscriber: yota9. · View Herald TranscriptNov 18 2022, 8:36 AM
thakis mentioned this in D130034: [BOLT] Add BinaryContext::IsStripped.Nov 18 2022, 8:37 AM
Harbormaster completed remote builds in B198486: Diff 476495.Nov 18 2022, 8:56 AM
maksfb accepted this revision.Nov 18 2022, 9:08 AM

Thanks for the fix.

This revision is now accepted and ready to land.Nov 18 2022, 9:08 AM
Closed by commit rG685f671e1d00: [bolt] Pass %cflags in test/X86/is-strip.s (authored by thakis). · Explain WhyNov 18 2022, 9:09 AM
This revision was automatically updated to reflect the committed changes.
thakis added a commit: rG685f671e1d00: [bolt] Pass %cflags in test/X86/is-strip.s.
Herald added a project: Restricted Project. · View Herald TranscriptNov 18 2022, 9:09 AM

Revision Contents

PathSize
bolt/
test/
X86/
2 lines

Diff 476508

bolt/test/X86/is-strip.s

# This test checks whether a binary is stripped or not. # This test checks whether a binary is stripped or not.
# RUN: %clang++ %p/Inputs/linenumber.cpp -o %t -Wl,-q # RUN: %clang++ %cflags %p/Inputs/linenumber.cpp -o %t -Wl,-q
# RUN: llvm-bolt %t -o %t.out 2>&1 | FileCheck %s -check-prefix=CHECK-NOSTRIP # RUN: llvm-bolt %t -o %t.out 2>&1 | FileCheck %s -check-prefix=CHECK-NOSTRIP
# RUN: cp %t %t.stripped # RUN: cp %t %t.stripped
# RUN: llvm-strip -s %t.stripped # RUN: llvm-strip -s %t.stripped
# RUN: llvm-bolt %t.stripped -o %t.out 2>&1 | FileCheck %s -check-prefix=CHECK-STRIP # RUN: llvm-bolt %t.stripped -o %t.out 2>&1 | FileCheck %s -check-prefix=CHECK-STRIP
# CHECK-NOSTRIP-NOT: BOLT-INFO: input binary is stripped. The support is limited and is considered experimental. # CHECK-NOSTRIP-NOT: BOLT-INFO: input binary is stripped. The support is limited and is considered experimental.
# CHECK-STRIP: BOLT-INFO: input binary is stripped. The support is limited and is considered experimental. # CHECK-STRIP: BOLT-INFO: input binary is stripped. The support is limited and is considered experimental.