This is an archive of the discontinued LLVM Phabricator instance.

[bolt] Clean up lit site cfg files a bit
ClosedPublic

Authored by thakis on Nov 18 2022, 7:41 AM.

Details

Summary
  • Stop setting config.python_executable in Unit/lit.site.cfg.py.in. All other projects only set this in the main lit config, not in the one for unit tests. (Unit tests don't spawn Python.)
  • Set config.python_executable to Python3_EXECUTABLE in main lit.site.cfg.py.in instead of PYTHON_EXECUTABLE. All other files did this in c4c3883b00.
  • Stop setting enable_abi_breaking_checks, enable_backtrace, enable_shared. Nothing in bolt's tests (or in lit) reads them.

Diff Detail

Event Timeline

thakis created this revision.Nov 18 2022, 7:41 AM
Herald added a reviewer: Amir. · View Herald Transcript
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
thakis requested review of this revision.Nov 18 2022, 7:41 AM
rafauler accepted this revision.Nov 18 2022, 9:02 AM

Thanks!

This revision is now accepted and ready to land.Nov 18 2022, 9:02 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptNov 18 2022, 9:07 AM