This is an archive of the discontinued LLVM Phabricator instance.

[MLIR] Fix incorrect assertion in memref replacement utility
ClosedPublic

Authored by bondhugula on Nov 17 2022, 2:21 AM.

Details

Summary

The assertion had an unchecked use of getDefiningOp. The condition
itself is stale and not needed. This is a trivial/obvious fix - the
buggy path wasn't exercised since the current passes/users of this
utility always passed the result of an op as an "extra index".

Diff Detail

Event Timeline

bondhugula created this revision.Nov 17 2022, 2:21 AM
bondhugula requested review of this revision.Nov 17 2022, 2:21 AM
ftynse accepted this revision.Nov 17 2022, 6:16 AM
This revision is now accepted and ready to land.Nov 17 2022, 6:16 AM
dcaballe accepted this revision.Nov 17 2022, 10:15 AM