This is an archive of the discontinued LLVM Phabricator instance.

Differential D138099

[BOLT][runtime] Change fPIE flag to fPIC
ClosedPublic

Authored by yota9 on Nov 16 2022, 12:16 AM.

Details

Reviewers
maksfb
rafauler
Amir
Commits
rG750d17bb72ad: [BOLT][runtime] Change fPIE flag to fPIC
Summary

Since instrumentation could be used on libraries we need to use fPIC,
not fPIE flag.

Diff Detail

Event Timeline

yota9 created this revision.Nov 16 2022, 12:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 16 2022, 12:16 AM
Herald added subscribers: treapster, ayermolo. · View Herald Transcript
yota9 requested review of this revision.Nov 16 2022, 12:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 16 2022, 12:16 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B197922: Diff 475707.Nov 16 2022, 12:33 AM
rafauler accepted this revision.Nov 16 2022, 3:37 PM

LGTM

This revision is now accepted and ready to land.Nov 16 2022, 3:37 PM
Closed by commit rG750d17bb72ad: [BOLT][runtime] Change fPIE flag to fPIC (authored by yota9). · Explain WhyNov 16 2022, 11:51 PM
This revision was automatically updated to reflect the committed changes.
yota9 added a commit: rG750d17bb72ad: [BOLT][runtime] Change fPIE flag to fPIC.

Revision Contents

PathSize
bolt/
runtime/
2 lines

Diff 476025

bolt/runtime/CMakeLists.txt

Show All 22 Lines
set_target_properties(bolt_rt_hugify PROPERTIES LIBRARY_OUTPUT_DIRECTORY "lib${LLVM_LIBDIR_SUFFIX}") set_target_properties(bolt_rt_hugify PROPERTIES LIBRARY_OUTPUT_DIRECTORY "lib${LLVM_LIBDIR_SUFFIX}")
set(BOLT_RT_FLAGS set(BOLT_RT_FLAGS
-ffreestanding -ffreestanding
-fno-exceptions -fno-exceptions
-fno-rtti -fno-rtti
-fno-stack-protector -fno-stack-protector
-mno-sse -mno-sse
-fPIE) -fPIC)
# Don't let the compiler think it can create calls to standard libs # Don't let the compiler think it can create calls to standard libs
target_compile_options(bolt_rt_instr PRIVATE ${BOLT_RT_FLAGS}) target_compile_options(bolt_rt_instr PRIVATE ${BOLT_RT_FLAGS})
target_include_directories(bolt_rt_instr PRIVATE ${CMAKE_CURRENT_BINARY_DIR}) target_include_directories(bolt_rt_instr PRIVATE ${CMAKE_CURRENT_BINARY_DIR})
target_compile_options(bolt_rt_hugify PRIVATE ${BOLT_RT_FLAGS}) target_compile_options(bolt_rt_hugify PRIVATE ${BOLT_RT_FLAGS})
target_include_directories(bolt_rt_hugify PRIVATE ${CMAKE_CURRENT_BINARY_DIR}) target_include_directories(bolt_rt_hugify PRIVATE ${CMAKE_CURRENT_BINARY_DIR})
install(TARGETS bolt_rt_instr DESTINATION "lib${LLVM_LIBDIR_SUFFIX}") install(TARGETS bolt_rt_instr DESTINATION "lib${LLVM_LIBDIR_SUFFIX}")
Show All 14 Lines