This is an archive of the discontinued LLVM Phabricator instance.

[BinaryFormat] Add LoongArch
ClosedPublic

Authored by xen0n on Nov 15 2022, 2:29 AM.

Diff Detail

Event Timeline

xen0n created this revision.Nov 15 2022, 2:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 15 2022, 2:29 AM
xen0n requested review of this revision.Nov 15 2022, 2:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 15 2022, 2:29 AM

Very straightforward but could you add some tests?

xen0n added a comment.Nov 16 2022, 2:53 AM

Very straightforward but could you add some tests?

Hmm, it seems the two methods are not currently covered by unit tests. Do I have to add something new?

MaskRay accepted this revision.Nov 16 2022, 1:47 PM

This was added for llvm-ifs which did not have thorough tests [Facepalm].

This revision is now accepted and ready to land.Nov 16 2022, 1:47 PM
This revision was landed with ongoing or failed builds.Nov 16 2022, 8:02 PM
This revision was automatically updated to reflect the committed changes.