This is an archive of the discontinued LLVM Phabricator instance.

[asan][darwin] This test is x86_64 specific, not non-ios in general.
ClosedPublic

Authored by rsundahl on Nov 14 2022, 6:33 PM.

Details

Summary

This test was unsupported in iOS when a more accurate test is that the architecture is x86_64. This "fix" is first in a series of updates intended to get asan arm64 tests fully functional.

Diff Detail

Event Timeline

rsundahl created this revision.Nov 14 2022, 6:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 14 2022, 6:33 PM
Herald added a subscriber: Enna1. · View Herald Transcript
rsundahl requested review of this revision.Nov 14 2022, 6:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 14 2022, 6:33 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
rsundahl edited the summary of this revision. (Show Details)Nov 14 2022, 6:38 PM
thetruestblue accepted this revision.Nov 14 2022, 7:24 PM

Is there a radar tracking this that we can add to these updates?
LGTM.

This revision is now accepted and ready to land.Nov 14 2022, 7:24 PM
rsundahl edited reviewers, added: vitalybuka; removed: Vitaljaz.Nov 15 2022, 8:21 AM
vitalybuka accepted this revision.Nov 15 2022, 11:10 AM