[compiler-rt][hwasan] Do not call InitLoadedGlobals in __hwasan_init

[leonardchan]

Summary

Fuchsia's libc provides a new hook (sanitizer_module_loaded) which calls hwasan_library_loaded in the startup path which will register globals in loaded modules.

[mcgrathr]

lgtm

compiler-rt/lib/hwasan/hwasan.cpp

343

You could make this an if constexpr instead of #if to avoid the unused static function warning.

compiler-rt/lib/hwasan/hwasan.cpp

__attribute__((constructor(0))) void __hwasan_init() {
 
   __sanitizer_set_report_path(common_flags()->log_path);
 
   AndroidTestTlsSlot();
 
   DisableCoreDumperIfNecessary();
 
   InitInstrumentation();
+  if constexpr (!SANITIZER_FUCHSIA) {
+    // Fuchsia's libc provides a hook (__sanitizer_module_loaded) that runs on
+    // the startup path which calls into __hwasan_library_loaded on all
+    // initially loaded modules, so explicitly registering the globals here
+    // isn't needed.
     InitLoadedGlobals();
+  }
 
   // Needs to be called here because flags()->random_tags might not have been
   // initialized when InitInstrumentation() was called.
   GetCurrentThread()->EnsureRandomStateInited();
 
   SetPrintfAndReportCallback(AppendToErrorMessageBuffer);
   // This may call libc -> needs initialized shadow.
   AndroidLogInit();