This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt][hwasan] Call __hwasan_library_loaded via __sanitizer_library_loaded on Fuchsia
ClosedPublic

Authored by leonardchan on Sep 13 2022, 1:17 PM.

Diff Detail

Event Timeline

leonardchan created this revision.Sep 13 2022, 1:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 13 2022, 1:17 PM
leonardchan requested review of this revision.Sep 13 2022, 1:17 PM
Herald added a subscriber: Restricted Project. · View Herald TranscriptSep 13 2022, 1:17 PM
phosek accepted this revision.Sep 13 2022, 7:07 PM

LGTM

This revision is now accepted and ready to land.Sep 13 2022, 7:07 PM

We haven't quite worked out this signature on the Fuchsia side yet.
Also, this makes the dl_iterate_phdr sequence in InitLoadedGlobals redundant so we should remove that for the Fuchsia configurations.

*ping* @mcgrathr Does this LGTY? D137676 also removes the redundant InitLoadedGlobals call.

mcgrathr accepted this revision.Nov 8 2022, 3:24 PM

lgtm