[LoongArch] Implement MCTargetExpr::fixELFSymbolsInTLSFixups hook

[wangleiat]

Remove irrelevant code.

[SixWeining]

LGTM and wait others.

[MaskRay]

This should use an assembly test at MC layer (llvm/test/MC)

llvm/test/CodeGen/LoongArch/tls-symbols.ll

1 ↗

(On Diff #473948)

remove <

12 ↗

(On Diff #473948)

It's better to use

CHECK-DAG to leave flexibility for MC to order symbol tables in another way. The symbol order is not guaranteed.

[wangleiat]

Address @MaskRay's comments and rebase.

[wangleiat]

In D137628#3920159, @MaskRay wrote:

This should use an assembly test at MC layer (llvm/test/MC)

Thanks a lot, it's done.

llvm/test/CodeGen/LoongArch/tls-symbols.ll

1 ↗

(On Diff #473948)

thanks

12 ↗

(On Diff #473948)

It's better to use

CHECK-DAG to leave flexibility for MC to order symbol tables in another way. The symbol order is not guaranteed.

thanks!

[MaskRay]

llvm/test/MC/LoongArch/Misc/tls-symbols.s

1

remove <

it's conventional to use -o %t and llvm-readobj -s %t

7

{{.*}} can be expanded to GLOBAL DEFAULT. Only a few more characters but check some properties which could be useful.

[wangleiat]

Use llvm-readobj for test.
Use CHECK directly, since the location doesn't change in the .s file?

[wangleiat]

llvm/test/MC/LoongArch/Misc/tls-symbols.s

7

{{.*}} can be expanded to GLOBAL DEFAULT. Only a few more characters but check some properties which could be useful.

thanks！

llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchMCExpr.h

public:
   void printImpl(raw_ostream &OS, const MCAsmInfo *MAI) const override;
   bool evaluateAsRelocatableImpl(MCValue &Res, const MCAsmLayout *Layout,
                                  const MCFixup *Fixup) const override;
   void visitUsedExpr(MCStreamer &Streamer) const override;
   MCFragment *findAssociatedFragment() const override {
     return getSubExpr()->findAssociatedFragment();
   }
 
-  void fixELFSymbolsInTLSFixups(MCAssembler &Asm) const override {}
+  void fixELFSymbolsInTLSFixups(MCAssembler &Asm) const override;
 
   static bool classof(const MCExpr *E) {
     return E->getKind() == MCExpr::Target;
   }
 
   static StringRef getVariantKindName(VariantKind Kind);
   static VariantKind getVariantKindForName(StringRef name);
 };
 
 } // end namespace llvm
 
 #endif

llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchMCExpr.cpp

 //
 //===----------------------------------------------------------------------===//
 
 #include "LoongArchMCExpr.h"
 #include "LoongArchAsmBackend.h"
 #include "LoongArchFixupKinds.h"
 #include "llvm/MC/MCContext.h"
 #include "llvm/MC/MCStreamer.h"
+#include "llvm/MC/MCSymbolELF.h"
 #include "llvm/MC/MCValue.h"
+#include "llvm/Support/Casting.h"
 #include "llvm/Support/ErrorHandling.h"
 
 using namespace llvm;
 
 #define DEBUG_TYPE "loongarch-mcexpr"
 
 const LoongArchMCExpr *
 LoongArchMCExpr::create(const MCExpr *Expr, VariantKind Kind, MCContext &Ctx) {
return StringSwitch<LoongArchMCExpr::VariantKind>(name)
       .Case("ie64_lo20", VK_LoongArch_TLS_IE64_LO20)
       .Case("ie64_hi12", VK_LoongArch_TLS_IE64_HI12)
       .Case("ld_pc_hi20", VK_LoongArch_TLS_LD_PC_HI20)
       .Case("ld_hi20", VK_LoongArch_TLS_LD_HI20)
       .Case("gd_pc_hi20", VK_LoongArch_TLS_GD_PC_HI20)
       .Case("gd_hi20", VK_LoongArch_TLS_GD_HI20)
       .Default(VK_LoongArch_Invalid);
 }
+
+static void fixELFSymbolsInTLSFixupsImpl(const MCExpr *Expr, MCAssembler &Asm) {
+  switch (Expr->getKind()) {
+  case MCExpr::Target:
+    llvm_unreachable("Can't handle nested target expression");
+    break;
+  case MCExpr::Constant:
+    break;
+  case MCExpr::Unary:
+    fixELFSymbolsInTLSFixupsImpl(cast<MCUnaryExpr>(Expr)->getSubExpr(), Asm);
+    break;
+  case MCExpr::Binary: {
+    const MCBinaryExpr *BE = cast<MCBinaryExpr>(Expr);
+    fixELFSymbolsInTLSFixupsImpl(BE->getLHS(), Asm);
+    fixELFSymbolsInTLSFixupsImpl(BE->getRHS(), Asm);
+    break;
+  }
+  case MCExpr::SymbolRef: {
+    // We're known to be under a TLS fixup, so any symbol should be
+    // modified. There should be only one.
+    const MCSymbolRefExpr &SymRef = *cast<MCSymbolRefExpr>(Expr);
+    cast<MCSymbolELF>(SymRef.getSymbol()).setType(ELF::STT_TLS);
+    break;
+  }
+  }
+}
+
+void LoongArchMCExpr::fixELFSymbolsInTLSFixups(MCAssembler &Asm) const {
+  switch (getKind()) {
+  default:
+    return;
+  case VK_LoongArch_TLS_LE_HI20:
+  case VK_LoongArch_TLS_IE_PC_HI20:
+  case VK_LoongArch_TLS_IE_HI20:
+  case VK_LoongArch_TLS_LD_PC_HI20:
+  case VK_LoongArch_TLS_LD_HI20:
+  case VK_LoongArch_TLS_GD_PC_HI20:
+  case VK_LoongArch_TLS_GD_HI20:
+    break;
+  }
+  fixELFSymbolsInTLSFixupsImpl(getSubExpr(), Asm);
+}

llvm/test/MC/LoongArch/Misc/tls-symbols.s

+# RUN: llvm-mc --triple=loongarch64 --filetype=obj < %s \
+# RUN:     | llvm-readelf -s - | FileCheck %s
+
+# CHECK-LABEL: Symbol table
+
+lu12i.w $a1, %gd_hi20(gd_abs)
+# CHECK-DAG: TLS{{.*}}UND gd_abs
+
+pcalau12i $a1, %gd_pc_hi20(gd_pcrel)
+# CHECK-DAG: TLS{{.*}}UND gd_pcrel
+
+lu12i.w $a1, %ld_hi20(ld_abs)
+# CHECK-DAG: TLS{{.*}}UND ld_abs
+
+pcalau12i $a1, %ld_pc_hi20(ld_pcrel)
+# CHECK-DAG: TLS{{.*}}UND ld_pcrel
+
+lu12i.w $a1, %ie_hi20(ie_abs)
+# CHECK-DAG: TLS{{.*}}UND ie_abs
+
+pcalau12i $a1, %ie_pc_hi20(ie_pcrel)
+# CHECK-DAG: TLS{{.*}}UND ie_pcrel
+
+lu12i.w $a1, %le_hi20(le)
+# CHECK-DAG: TLS{{.*}}UND le