[TypePromotion] Replace Zext to Truncate for the case src bitwidth is larger

[bcl5980]

Summary

Fix: https://github.com/llvm/llvm-project/issues/58843

[samtebbs]

llvm/lib/CodeGen/TypePromotion.cpp

582

Small nit: "need replace to" to "need to be replaced with"

llvm/test/Transforms/TypePromotion/AArch64/pr58843.ll

1

Since this is a midend change I think a target-agnostic test would be better.

[bcl5980]

llvm/test/Transforms/TypePromotion/AArch64/pr58843.ll

1

This pass need some target-dependent informations like RegisterBitWidth, TLI->getTypeAction(*Ctx, SrcVT).
And the crash can't be reproduced on x86_64 and riscv64. So a target-agnostic test is a little tricky here I think.

[samtebbs]

llvm/test/Transforms/TypePromotion/AArch64/pr58843.ll

1

OK that makes sense, I'm happy with this change with the two other minor changes suggested.

4

It looks like other tests in this directory remove this line and instead add -mtriple=aarch64 to the RUN line.

[bcl5980]

address comments.

[samtebbs]

Nice one, LGTM.

llvm/lib/CodeGen/TypePromotion.cpp

for (unsigned i = 0; i < I->getNumOperands(); ++i) {
       }
     }
   }
 }
 
 void IRPromoter::Cleanup() {
   LLVM_DEBUG(dbgs() << "IR Promotion: Cleanup..\n");
   // Some zexts will now have become redundant, along with their trunc
-  // operands, so remove them
+  // operands, so remove them.
+  // Some zexts need replace to truncate if src bitwidth is larger.
   for (auto *V : Visited) {
     if (!isa<ZExtInst>(V))
       continue;
 
     auto ZExt = cast<ZExtInst>(V);
     if (ZExt->getDestTy() != ExtTy)
       continue;
 
     Value *Src = ZExt->getOperand(0);
     if (ZExt->getSrcTy() == ZExt->getDestTy()) {
       LLVM_DEBUG(dbgs() << "IR Promotion: Removing unnecessary cast: " << *ZExt
                         << "\n");
       ReplaceAllUsersOfWith(ZExt, Src);
       continue;
+    } else if (ZExt->getSrcTy()->getScalarSizeInBits() > PromotedWidth) {
+      IRBuilder<> Builder{ZExt};
+      Value *Trunc = Builder.CreateTrunc(Src, ZExt->getDestTy());
+      ReplaceAllUsersOfWith(ZExt, Trunc);
+      continue;
     }
 
     // We've inserted a trunc for a zext sink, but we already know that the
     // input is in range, negating the need for the trunc.
     if (NewInsts.count(Src) && isa<TruncInst>(Src)) {
       auto *Trunc = cast<TruncInst>(Src);
       assert(Trunc->getOperand(0)->getType() == ExtTy &&
              "expected inserted trunc to be operating on i32");

llvm/test/Transforms/TypePromotion/AArch64/pr58843.ll

+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -type-promotion -verify -S %s -o - | FileCheck %s
+target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128"
+target triple = "aarch64-unknown-linux-gnu"
+
+; Check the case don't crash due to zext source type bitwidth 
+; larger than dest type bitwidth.
+define i1 @test(i8 %arg) {
+; CHECK-LABEL: @test(
+; CHECK-NEXT:    [[EXT1:%.*]] = zext i8 [[ARG:%.*]] to i64
+; CHECK-NEXT:    [[TMP1:%.*]] = and i64 [[EXT1]], 7
+; CHECK-NEXT:    [[TMP2:%.*]] = trunc i64 [[TMP1]] to i32
+; CHECK-NEXT:    [[CMP:%.*]] = icmp ne i32 [[TMP2]], 0
+; CHECK-NEXT:    ret i1 [[CMP]]
+;
+  %ext1 = zext i8 %arg to i64
+  %trunc = trunc i64 %ext1 to i3
+  %ext2 = zext i3 %trunc to i8
+  %cmp = icmp ne i8 %ext2, 0
+  ret i1 %cmp
+}