Page MenuHomePhabricator

[CodeGen] Refactor ExpandBVWithShuffles. NFC.
AcceptedPublic

Authored by HanKuanChen on Nov 7 2022, 10:37 PM.

Details

Summary

Phase 0 is used to detect whether a vector_shuffle is supported. But we
can check a vector_shuffle is legal just before calling
getVectorShuffle.

Diff Detail

Unit TestsFailed

TimeTest
60,050 msx64 debian > libFuzzer.libFuzzer::fuzzer-leak.test
Script: -- : 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -O2 -gline-tables-only -fsanitize=address,fuzzer -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/lib/fuzzer -m64 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/fuzzer/LeakTest.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/fuzzer/X86_64DefaultLinuxConfig/Output/fuzzer-leak.test.tmp-LeakTest
60,040 msx64 debian > libFuzzer.libFuzzer::value-profile-load.test
Script: -- : 'RUN: at line 2'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -O2 -gline-tables-only -fsanitize=address,fuzzer -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/lib/fuzzer -m64 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/fuzzer/LoadTest.cpp -fsanitize-coverage=trace-gep -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/fuzzer/X86_64DefaultLinuxConfig/Output/value-profile-load.test.tmp-LoadTest

Event Timeline

HanKuanChen created this revision.Nov 7 2022, 10:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 7 2022, 10:37 PM
HanKuanChen requested review of this revision.Nov 7 2022, 10:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 7 2022, 10:37 PM
spatel accepted this revision.Nov 8 2022, 5:32 AM

LGTM - seems like a nice cleanup.

This revision is now accepted and ready to land.Nov 8 2022, 5:32 AM