Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
openmp/runtime/test/tasking/hidden_helper_task/common.h | ||
---|---|---|
9 | Technically these should be std::int32_t, etc. From the C++ standard: All library entities except operator new and operator delete are defined within the namespace std or namespaces nested within namespace std. (footnote 166) 166) The C standard library headers (Annex D.5) also define names within the global namespace, while the C++ headers for C library facilities (20.5.1.2) may also define names within the global namespace. Note that it's a "may", not "must". This diff is a portability improvement, so I think it's better to "do things correctly now" and add std::. |
openmp/runtime/test/tasking/hidden_helper_task/common.h | ||
---|---|---|
9 | It is a "may" in the standard wording but the real world practice is that everything will break if you remove ::int32_t from cstdint. All supported C++ standard libraries provide ::int32_t. I am not fussed about this difference, but cstdint needs to be ordered in the header list, fixing clang-format. |
openmp/runtime/test/tasking/hidden_helper_task/common.h | ||
---|---|---|
9 | Thanks. |
I've revised the patch title and summary for you; it's trivial and self-explaining enough to not need the error output and verbose explanation.
Technically these should be std::int32_t, etc. From the C++ standard:
Note that it's a "may", not "must".
This diff is a portability improvement, so I think it's better to "do things correctly now" and add std::.