This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Merge GlobalISel tests into SelectionDAG tests. NFC.
ClosedPublic

Authored by foad on Nov 6 2022, 11:38 PM.

Details

Summary

Remove GlobalISel test files that only contained RUN lines running the
code from the SelectionDAG version of the same test.

Diff Detail

Event Timeline

foad created this revision.Nov 6 2022, 11:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 6 2022, 11:38 PM
foad requested review of this revision.Nov 6 2022, 11:38 PM
foad added inline comments.Nov 6 2022, 11:40 PM
llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.ds.consume.ll
1–4

This was testing append instead of consume by mistake.

llvm/test/CodeGen/AMDGPU/llvm.amdgcn.ds.append.ll
2

XUN should be fixed but it wasn't trivial enough to include in this patch.

llvm/test/CodeGen/AMDGPU/llvm.amdgcn.ds.consume.ll
2

XUN should be fixed but it wasn't trivial enough to include in this patch.

arsenm accepted this revision.Nov 7 2022, 9:36 AM

LGTM. The clean separation of tests has been gone for a while

This revision is now accepted and ready to land.Nov 7 2022, 9:36 AM
This revision was automatically updated to reflect the committed changes.
llvm/test/CodeGen/AMDGPU/GlobalISel/read_register.ll