This is an archive of the discontinued LLVM Phabricator instance.

Differential D137380

[mlir] Drop `const` from `SymbolTableCollection::lookupSymbolIn`
ClosedPublic

Authored by Mogball on Nov 3 2022, 6:41 PM.

Details

Reviewers
rriddle
Commits
rGf530e6e34ee1: [mlir] Drop `const` from `SymbolTableCollection::lookupSymbolIn`
Summary

This function didn't work because it was marked const but both functions
it could dispatch to are not.

Diff Detail

Event Timeline

Mogball created this revision.Nov 3 2022, 6:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 3 2022, 6:41 PM
Herald added subscribers: Moerafaat, zero9178, bzcheeseman and 19 others. · View Herald Transcript
Mogball requested review of this revision.Nov 3 2022, 6:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 3 2022, 6:41 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
rriddle accepted this revision.Nov 3 2022, 6:42 PM
This revision is now accepted and ready to land.Nov 3 2022, 6:42 PM
Harbormaster completed remote builds in B196043: Diff 473099.Nov 3 2022, 7:08 PM
Closed by commit rGf530e6e34ee1: [mlir] Drop `const` from `SymbolTableCollection::lookupSymbolIn` (authored by Mogball). · Explain WhyNov 5 2022, 4:28 PM
This revision was automatically updated to reflect the committed changes.
Mogball added a commit: rGf530e6e34ee1: [mlir] Drop `const` from `SymbolTableCollection::lookupSymbolIn`.

Revision Contents

PathSize
mlir/
include/
mlir/
IR/
2 lines

Diff 473099

mlir/include/mlir/IR/SymbolTable.h

Show First 20 Lines • Show All 243 Lines • ▼ Show 20 Lines
/// unnecessary tables. /// unnecessary tables.
class SymbolTableCollection { class SymbolTableCollection {
public: public:
/// Look up a symbol with the specified name within the specified symbol table /// Look up a symbol with the specified name within the specified symbol table
/// operation, returning null if no such name exists. /// operation, returning null if no such name exists.
Operation *lookupSymbolIn(Operation *symbolTableOp, StringAttr symbol); Operation *lookupSymbolIn(Operation *symbolTableOp, StringAttr symbol);
Operation *lookupSymbolIn(Operation *symbolTableOp, SymbolRefAttr name); Operation *lookupSymbolIn(Operation *symbolTableOp, SymbolRefAttr name);
template <typename T, typename NameT> template <typename T, typename NameT>
T lookupSymbolIn(Operation *symbolTableOp, NameT &&name) const { T lookupSymbolIn(Operation *symbolTableOp, NameT &&name) {
return dyn_cast_or_null<T>( return dyn_cast_or_null<T>(
lookupSymbolIn(symbolTableOp, std::forward<NameT>(name))); lookupSymbolIn(symbolTableOp, std::forward<NameT>(name)));
} }
/// A variant of 'lookupSymbolIn' that returns all of the symbols referenced /// A variant of 'lookupSymbolIn' that returns all of the symbols referenced
/// by a given SymbolRefAttr when resolved within the provided symbol table /// by a given SymbolRefAttr when resolved within the provided symbol table
/// operation. Returns failure if any of the nested references could not be /// operation. Returns failure if any of the nested references could not be
/// resolved. /// resolved.
LogicalResult lookupSymbolIn(Operation *symbolTableOp, SymbolRefAttr name, LogicalResult lookupSymbolIn(Operation *symbolTableOp, SymbolRefAttr name,
▲ Show 20 Lines • Show All 132 Lines • Show Last 20 Lines