This is an archive of the discontinued LLVM Phabricator instance.

[LLDB] [LoongArch] Add loongarch64 case in ComputeHostArchitectureSupport()
ClosedPublic

Authored by seehearfeel on Nov 2 2022, 7:31 PM.

Details

Summary

This is a simple change, loongarch64 host also supports 32-bit binaries,
so note it.

Without this patch:

[loongson@linux build]$ ./tools/lldb/unittests/Host/HostTests | tail -6
[==========] 78 tests from 18 test suites ran. (16 ms total)
[  PASSED  ] 77 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] HostTest.GetProcessInfo

 1 FAILED TEST

With this patch:

[loongson@linux build]$ ./tools/lldb/unittests/Host/HostTests | tail -2
[==========] 78 tests from 18 test suites ran. (15 ms total)
[  PASSED  ] 78 tests.

Diff Detail

Event Timeline

seehearfeel created this revision.Nov 2 2022, 7:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 2 2022, 7:31 PM
Herald added a subscriber: StephenFan. · View Herald Transcript
seehearfeel requested review of this revision.Nov 2 2022, 7:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 2 2022, 7:31 PM
xen0n accepted this revision.Nov 2 2022, 8:15 PM

Trivially correct. CONFIG_COMPAT isn't yet supported by upstream Linux though, but preemptively adding LoongArch here won't do any harm.

This revision is now accepted and ready to land.Nov 2 2022, 8:15 PM
DavidSpickett accepted this revision.Nov 3 2022, 2:47 AM

LGTM. Follows the same logic AArch64 does. (meaning: we don't support debugging 32 bit from a 64 bit lldb very well, if it all, but it's still noted here as possible)

MaskRay accepted this revision.Nov 3 2022, 6:07 PM
SixWeining accepted this revision.Nov 3 2022, 7:28 PM