Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

seehearfeel (Tiezhu Yang)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 23 2022, 8:41 PM (48 w, 4 d)

Recent Activity

Dec 7 2022

seehearfeel added inline comments to D139158: [LLDB][LoongArch] Make software single stepping work.
Dec 7 2022, 11:14 PM · Restricted Project, Restricted Project

Nov 23 2022

seehearfeel updated the diff for D138407: [LLDB] Add LoongArch register definitions and operations.

(1) define *_OFFSET in RegisterInfoPOSIX_loongarch64.cpp
(2) remove the alias u0 for r21, use fp and s9 for r22

Nov 23 2022, 11:58 PM · Restricted Project, Restricted Project
seehearfeel added inline comments to D138407: [LLDB] Add LoongArch register definitions and operations.
Nov 23 2022, 11:42 PM · Restricted Project, Restricted Project
seehearfeel updated the diff for D138407: [LLDB] Add LoongArch register definitions and operations.

(1) Put elf.h before sys/uio.h
(2) Remove unnecessary indent
(3) Remove const cast of data_sp->GetBytes()
(4) Return k_num_register_sets in GetRegisterSetCount()
(5) Add register name alias

Nov 23 2022, 4:40 PM · Restricted Project, Restricted Project
seehearfeel added inline comments to D138407: [LLDB] Add LoongArch register definitions and operations.
Nov 23 2022, 4:19 AM · Restricted Project, Restricted Project
seehearfeel added inline comments to D138407: [LLDB] Add LoongArch register definitions and operations.
Nov 23 2022, 1:57 AM · Restricted Project, Restricted Project

Nov 21 2022

seehearfeel requested review of D138407: [LLDB] Add LoongArch register definitions and operations.
Nov 21 2022, 1:33 AM · Restricted Project, Restricted Project

Nov 6 2022

seehearfeel updated the diff for D137519: [LLDB] Add LoongArch software breakpoint trap opcode.

Use "break 0x5" in the code comment.

Nov 6 2022, 7:09 PM · Restricted Project, Restricted Project
seehearfeel requested review of D137519: [LLDB] Add LoongArch software breakpoint trap opcode.
Nov 6 2022, 6:09 PM · Restricted Project, Restricted Project

Nov 2 2022

seehearfeel requested review of D137312: [LLDB] [LoongArch] Add loongarch64 case in ComputeHostArchitectureSupport().
Nov 2 2022, 7:31 PM · Restricted Project, Restricted Project

Oct 31 2022

seehearfeel updated subscribers of D137041: [LLDB] Optimize lldb build time and memory consumption..

c++: fatal error: Killed signal terminated program cc1plus due to out of memory
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107483

Oct 31 2022, 6:56 PM · Restricted Project
seehearfeel updated the diff for D137057: [LLDB][LoongArch] Add LoongArch ArchSpec and subtype detection.

(1) Rename LOONGARCHSubType to LoongArchSubType
(2) Define min_opcode_byte_size as 4 for LoongArch

Oct 31 2022, 5:13 AM · Restricted Project, Restricted Project
seehearfeel added a comment to D137057: [LLDB][LoongArch] Add LoongArch ArchSpec and subtype detection.

Looks good to me.

Oct 31 2022, 4:49 AM · Restricted Project, Restricted Project
seehearfeel added inline comments to D137057: [LLDB][LoongArch] Add LoongArch ArchSpec and subtype detection.
Oct 31 2022, 4:22 AM · Restricted Project, Restricted Project
seehearfeel requested review of D137057: [LLDB][LoongArch] Add LoongArch ArchSpec and subtype detection.
Oct 31 2022, 12:43 AM · Restricted Project, Restricted Project

Oct 30 2022

seehearfeel added a comment to D137041: [LLDB] Optimize lldb build time and memory consumption..

Thank you for your patch.
It seems there is a new problem with this patch.

Oct 30 2022, 7:33 PM · Restricted Project
seehearfeel added a comment to D136362: [LLDB][RISCV] Add RV64C instruction support for EmulateInstructionRISCV.

I can reproduce this issue on x86_64 used with the latest gcc.

Oct 30 2022, 7:18 PM · Restricted Project, Restricted Project, Restricted Project

Oct 28 2022

seehearfeel updated subscribers of D136362: [LLDB][RISCV] Add RV64C instruction support for EmulateInstructionRISCV.

Can you give us:

  • the full cmake command you used to configure the project
Oct 28 2022, 1:09 AM · Restricted Project, Restricted Project, Restricted Project

Oct 27 2022

seehearfeel added a comment to D136362: [LLDB][RISCV] Add RV64C instruction support for EmulateInstructionRISCV.

After commit 05ae747a5353811f93f5814f24d2335e6229d78a ("[LLDB][RISCV] Add RV64C instruction support for EmulateInstructionRISCV"),
build failed when "ninja check-lldb" on my local machine:

[1/3] Building CXX object tools/lldb/unittests/Instruction/CMakeFiles/EmulatorTests.dir/RISCV/TestRISCVEmulator.cpp.o
FAILED: tools/lldb/unittests/Instruction/CMakeFiles/EmulatorTests.dir/RISCV/TestRISCVEmulator.cpp.o 
/usr/bin/c++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/loongson/llvm-project/llvm/build/tools/lldb/unittests/Instruction -I/home/loongson/llvm-project/lldb/unittests/Instruction -I/home/loongson/llvm-project/lldb/include -I/home/loongson/llvm-project/llvm/build/tools/lldb/include -I/home/loongson/llvm-project/llvm/build/include -I/home/loongson/llvm-project/llvm/include -I/home/loongson/llvm-project/llvm/../clang/include -I/home/loongson/llvm-project/llvm/build/tools/lldb/../clang/include -I/home/loongson/llvm-project/lldb/source -I/home/loongson/llvm-project/lldb/unittests -I/home/loongson/llvm-project/llvm/utils/unittest/googletest/include -I/home/loongson/llvm-project/llvm/utils/unittest/googlemock/include -isystem /usr/include/libxml2 -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-deprecated-declarations -Wno-unknown-pragmas -Wno-strict-aliasing -Wno-stringop-truncation -O3 -DNDEBUG  -include /home/loongson/llvm-project/lldb/unittests/gtest_common.h -Wno-variadic-macros -fno-exceptions -fno-rtti -Wno-suggest-override -std=c++17 -MD -MT tools/lldb/unittests/Instruction/CMakeFiles/EmulatorTests.dir/RISCV/TestRISCVEmulator.cpp.o -MF tools/lldb/unittests/Instruction/CMakeFiles/EmulatorTests.dir/RISCV/TestRISCVEmulator.cpp.o.d -o tools/lldb/unittests/Instruction/CMakeFiles/EmulatorTests.dir/RISCV/TestRISCVEmulator.cpp.o -c /home/loongson/llvm-project/lldb/unittests/Instruction/RISCV/TestRISCVEmulator.cpp
c++: fatal error: Killed signal terminated program cc1plus
compilation terminated.
ninja: build stopped: subcommand failed.

After revert the changes in lldb/unittests/Instruction/RISCV/TestRISCVEmulator.cpp, build successful.

I failed to repro this error. :(

c++: fatal error: Killed signal terminated program cc1plus

With such a vague error message it is hard to find the problematic part and it does not look like a code problem. Would you mind checking your build configuration and trying ninja check-lldb -j1 for detailed information?

Oct 27 2022, 6:52 PM · Restricted Project, Restricted Project, Restricted Project
seehearfeel added a comment to D136362: [LLDB][RISCV] Add RV64C instruction support for EmulateInstructionRISCV.

After commit 05ae747a5353811f93f5814f24d2335e6229d78a ("[LLDB][RISCV] Add RV64C instruction support for EmulateInstructionRISCV"),
build failed when "ninja check-lldb" on my local machine:

[1/3] Building CXX object tools/lldb/unittests/Instruction/CMakeFiles/EmulatorTests.dir/RISCV/TestRISCVEmulator.cpp.o
FAILED: tools/lldb/unittests/Instruction/CMakeFiles/EmulatorTests.dir/RISCV/TestRISCVEmulator.cpp.o 
/usr/bin/c++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/loongson/llvm-project/llvm/build/tools/lldb/unittests/Instruction -I/home/loongson/llvm-project/lldb/unittests/Instruction -I/home/loongson/llvm-project/lldb/include -I/home/loongson/llvm-project/llvm/build/tools/lldb/include -I/home/loongson/llvm-project/llvm/build/include -I/home/loongson/llvm-project/llvm/include -I/home/loongson/llvm-project/llvm/../clang/include -I/home/loongson/llvm-project/llvm/build/tools/lldb/../clang/include -I/home/loongson/llvm-project/lldb/source -I/home/loongson/llvm-project/lldb/unittests -I/home/loongson/llvm-project/llvm/utils/unittest/googletest/include -I/home/loongson/llvm-project/llvm/utils/unittest/googlemock/include -isystem /usr/include/libxml2 -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-deprecated-declarations -Wno-unknown-pragmas -Wno-strict-aliasing -Wno-stringop-truncation -O3 -DNDEBUG  -include /home/loongson/llvm-project/lldb/unittests/gtest_common.h -Wno-variadic-macros -fno-exceptions -fno-rtti -Wno-suggest-override -std=c++17 -MD -MT tools/lldb/unittests/Instruction/CMakeFiles/EmulatorTests.dir/RISCV/TestRISCVEmulator.cpp.o -MF tools/lldb/unittests/Instruction/CMakeFiles/EmulatorTests.dir/RISCV/TestRISCVEmulator.cpp.o.d -o tools/lldb/unittests/Instruction/CMakeFiles/EmulatorTests.dir/RISCV/TestRISCVEmulator.cpp.o -c /home/loongson/llvm-project/lldb/unittests/Instruction/RISCV/TestRISCVEmulator.cpp
c++: fatal error: Killed signal terminated program cc1plus
compilation terminated.
ninja: build stopped: subcommand failed.
Oct 27 2022, 2:57 AM · Restricted Project, Restricted Project, Restricted Project

Oct 25 2022

seehearfeel added a comment to D136578: [LLDB] [LoongArch] Add minimal LoongArch support.

This LGTM from the lldb side.

Oct 25 2022, 4:25 AM · Restricted Project, Restricted Project

Oct 24 2022

seehearfeel updated the diff for D136578: [LLDB] [LoongArch] Add minimal LoongArch support.

Remove GPRegSet and FPRegSet definitions which are not used in this commit.
Use git clang-format to format the patch properly.

Oct 24 2022, 6:11 PM · Restricted Project, Restricted Project
seehearfeel added inline comments to D136578: [LLDB] [LoongArch] Add minimal LoongArch support.
Oct 24 2022, 4:34 AM · Restricted Project, Restricted Project
seehearfeel added inline comments to D136578: [LLDB] [LoongArch] Add minimal LoongArch support.
Oct 24 2022, 2:45 AM · Restricted Project, Restricted Project
seehearfeel added a comment to D136578: [LLDB] [LoongArch] Add minimal LoongArch support.

Hi, I've edited the summary and patch title for you. It's generally not necessary to add that much "politeness" when most of it is obvious from context (e.g. the fact that you're new face here, that there's obviously no LoongArch support in LLDB, and most of the methods being stubs). It didn't help that much of the text was in Chinglish either.

As for the changes, they look reasonable to me, but as I haven't tested it out myself yet (and unable to, due to it being stub-only), I'll not give the approval myself this time. Thanks for your contribution and welcome!

Oct 24 2022, 2:37 AM · Restricted Project, Restricted Project

Oct 23 2022

seehearfeel updated the diff for D136578: [LLDB] [LoongArch] Add minimal LoongArch support.

Use git diff -U999999 to generate the patch so that we can get more context suggested by Weining.

Oct 23 2022, 11:50 PM · Restricted Project, Restricted Project
seehearfeel updated the summary of D136578: [LLDB] [LoongArch] Add minimal LoongArch support.
Oct 23 2022, 11:30 PM · Restricted Project, Restricted Project
seehearfeel requested review of D136578: [LLDB] [LoongArch] Add minimal LoongArch support.
Oct 23 2022, 11:24 PM · Restricted Project, Restricted Project