This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Granularize <concept> includes
ClosedPublic

Authored by philnik on Nov 2 2022, 12:28 PM.

Details

Diff Detail

Event Timeline

philnik created this revision.Nov 2 2022, 12:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 2 2022, 12:28 PM
philnik requested review of this revision.Nov 2 2022, 12:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 2 2022, 12:28 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript

Thanks a lot for working on this!
I just landed D137278, can you rebase this on main to see whether the CI is happy?

libcxx/test/libcxx/transitive_includes/cxx20.csv
666

unlike format, ranges is considered stable so we shouldn't remove this include here.

libcxx/test/libcxx/transitive_includes/cxx2b.csv
3

I think this removal isn't part of the release notes yet. Can you verify and add this header if needed.

philnik marked an inline comment as done.Nov 3 2022, 8:49 AM
philnik added inline comments.
libcxx/test/libcxx/transitive_includes/cxx20.csv
666

ranges wasn't stable in LLVM 15, so I think we can still consider it experimental until the LLVM 16 release branch.

libcxx/test/libcxx/transitive_includes/cxx2b.csv
3

<concepts> is already in the list.

ldionne accepted this revision.Nov 3 2022, 8:55 AM
ldionne added inline comments.
libcxx/include/functional
530

I think this TODO is not relevant anymore?

This revision is now accepted and ready to land.Nov 3 2022, 8:55 AM
philnik updated this revision to Diff 472999.Nov 3 2022, 11:54 AM
philnik marked an inline comment as done.
  • Rebased
  • Try to fix CI
philnik updated this revision to Diff 473432.Nov 5 2022, 8:37 AM

Try to fix CI

This revision was automatically updated to reflect the committed changes.
Mordante added inline comments.Nov 7 2022, 9:06 AM
libcxx/test/libcxx/transitive_includes/cxx20.csv
666

Ah I thought we manged to get that stable in time, then I agree we can remove them.

libcxx/test/libcxx/transitive_includes/cxx2b.csv
3

Thanks!