This is an archive of the discontinued LLVM Phabricator instance.

[llvm-config] Remove --src-root option
ClosedPublic

Authored by mgorny on Oct 31 2022, 10:35 PM.

Details

Summary

Remove the --src-root option from the deprecated llvm-config tool.
None of the llvm-project projects use this option anymore. The value
was only meaningful for in-tree use and usually became no longer correct
once LLVM was installed -- either because it was built in a temporary
directory, or installed from a binary package and built on a different
system entirely. Therefore, third-party tools could not have been
relying on it anyway.

The LLVM_SRC_ROOT #define is left intact, as it is used to compute
includedir when llvm-config is used in-source.

Diff Detail

Event Timeline

mgorny created this revision.Oct 31 2022, 10:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 31 2022, 10:35 PM
Herald added a subscriber: StephenFan. · View Herald Transcript
mgorny requested review of this revision.Oct 31 2022, 10:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 31 2022, 10:35 PM
This revision is now accepted and ready to land.Oct 31 2022, 10:38 PM
phosek accepted this revision.Oct 31 2022, 11:24 PM

LGTM

This revision was automatically updated to reflect the committed changes.