This is an archive of the discontinued LLVM Phabricator instance.

PPC: Implement null target streamer
ClosedPublic

Authored by arsenm on Oct 31 2022, 3:34 PM.

Details

Reviewers
nemanjai
kbarton
shchenz
Group Reviewers
Restricted Project

Diff Detail

Event Timeline

arsenm created this revision.Oct 31 2022, 3:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 31 2022, 3:34 PM
arsenm requested review of this revision.Oct 31 2022, 3:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 31 2022, 3:34 PM
Herald added a subscriber: wdng. · View Herald Transcript
qiucf added a reviewer: Restricted Project.Dec 13 2022, 1:56 AM
shchenz added inline comments.Dec 13 2022, 6:16 PM
llvm/lib/Target/PowerPC/PPCTargetStreamer.h
31

Instead of making the base PPCTargetStreamer as a null streamer, does it make more sense to add a new child class PPCTargetNullStreamer in lib/Target/PowerPC/MCTargetDesc/PPCMCTargetDesc.cpp?

arsenm added inline comments.Dec 13 2022, 7:22 PM
llvm/lib/Target/PowerPC/PPCTargetStreamer.h
31

More boilerplate for no gain

shchenz accepted this revision as: shchenz.Dec 13 2022, 7:34 PM

LGTM. Thanks for improving this for PPC.

llvm/lib/Target/PowerPC/PPCTargetStreamer.h
31

OK. Seems more targets reuse base class as null streamer.

This revision is now accepted and ready to land.Dec 13 2022, 7:34 PM