This is an archive of the discontinued LLVM Phabricator instance.

[flang] Add one missing "llvm_" prefix to gtest_main
ClosedPublic

Authored by mgorny on Oct 31 2022, 7:32 AM.

Details

Summary

The target_link_libraries() call operates on gtest_main rather than
llvm_gtest_main. I think it was missed while prefixing all the tools
in 38151a08c21e0cdacd52af03e4bdff258f0bac6f.

Diff Detail

Event Timeline

mgorny created this revision.Oct 31 2022, 7:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 31 2022, 7:32 AM
mgorny requested review of this revision.Oct 31 2022, 7:32 AM

Disclaimer: I haven't tested it but the buildbot seems to be fast in catching problems.

mgorny added a comment.Nov 3 2022, 9:43 AM

Gentle ping.

awarzynski accepted this revision.Nov 5 2022, 9:46 AM

Thanks for spotting and for fixing this. Yes, looks like an obvious omission in https://reviews.llvm.org/rG38151a08c21e0cdacd52af03e4bdff258f0bac6f. Since this is for standalone builds, you want to keep an eye on flang-aarch64-out-of-tree. That's the only bot that builds this configuration taht I am aware of.

LGTM!

This revision is now accepted and ready to land.Nov 5 2022, 9:46 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptNov 5 2022, 11:49 AM