This is an archive of the discontinued LLVM Phabricator instance.

Differential D137054

[X86][Driver] Remove stale FIXME. NFC
ClosedPublic

Authored by craig.topper on Oct 30 2022, 7:52 PM.

Details

Reviewers
pengfei
RKSimon
Commits
rG6fa0e3df97ac: [X86][Driver] Remove stale FIXME. NFC
Summary

We use getHostCPUFeatures in x86::getX86TargetFeatures so I think
this FIXME is taken care of already.

Diff Detail

Event Timeline

craig.topper created this revision.Oct 30 2022, 7:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 30 2022, 7:52 PM
Herald added a subscriber: StephenFan. · View Herald Transcript
craig.topper requested review of this revision.Oct 30 2022, 7:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 30 2022, 7:52 PM
Herald added subscribers: cfe-commits, MaskRay. · View Herald Transcript
Harbormaster completed remote builds in B195187: Diff 471893.Oct 30 2022, 8:29 PM
RKSimon accepted this revision.Oct 31 2022, 3:41 AM

LGTM

This revision is now accepted and ready to land.Oct 31 2022, 3:41 AM
Closed by commit rG6fa0e3df97ac: [X86][Driver] Remove stale FIXME. NFC (authored by craig.topper). · Explain WhyOct 31 2022, 10:41 AM
This revision was automatically updated to reflect the committed changes.
craig.topper added a commit: rG6fa0e3df97ac: [X86][Driver] Remove stale FIXME. NFC.

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
Arch/
3 lines

Diff 471893

clang/lib/Driver/ToolChains/Arch/X86.cpp

//===--- X86.cpp - X86 Helpers for Tools ------------------------*- C++ -*-===// //===--- X86.cpp - X86 Helpers for Tools ------------------------*- C++ -*-===//
Lint: Lint
Inline Actions

clang-format not found in user’s local PATH; not linting file.

Lint: Lint: clang-format not found in user’s local PATH; not linting file.
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
Show All 16 Linesstd::string x86::getX86TargetCPU(const Driver &D, const ArgList &Args,
const llvm::Triple &Triple) { const llvm::Triple &Triple) {
if (const Arg *A = Args.getLastArg(clang::driver::options::OPT_march_EQ)) { if (const Arg *A = Args.getLastArg(clang::driver::options::OPT_march_EQ)) {
StringRef CPU = A->getValue(); StringRef CPU = A->getValue();
if (CPU != "native") if (CPU != "native")
return std::string(CPU); return std::string(CPU);
// FIXME: Reject attempts to use -march=native unless the target matches // FIXME: Reject attempts to use -march=native unless the target matches
// the host. // the host.
//
// FIXME: We should also incorporate the detected target features for use
// with -native.
CPU = llvm::sys::getHostCPUName(); CPU = llvm::sys::getHostCPUName();
if (!CPU.empty() && CPU != "generic") if (!CPU.empty() && CPU != "generic")
return std::string(CPU); return std::string(CPU);
} }
if (const Arg *A = Args.getLastArg(options::OPT__SLASH_arch)) { if (const Arg *A = Args.getLastArg(options::OPT__SLASH_arch)) {
// Mapping built by looking at lib/Basic's X86TargetInfo::initFeatureMap(). // Mapping built by looking at lib/Basic's X86TargetInfo::initFeatureMap().
// The keys are case-sensitive; this matches link.exe. // The keys are case-sensitive; this matches link.exe.
▲ Show 20 Lines • Show All 221 Lines • Show Last 20 Lines