Page MenuHomePhabricator
Differential D137022

[libc++][chrono] Add calendar type formatters.
ClosedPublic
Actions

Authored by Mordante on Oct 29 2022, 8:55 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG105fef5dca7e: [libc++][chrono] Add calendar type formatters.
Summary

Some of the calendar types have landed before, this adds the missing
set. Note this does not complete the implementation of the chrono
formatters.

This removes the chrono header for some transitive include in C++17
mode. This is needed to avoid inclusion cycles.

Partially implements:

  • P1361 Integration of chrono with text formatting
  • P2372 Fixing locale handling in chrono formatters

Diff Detail

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Herald added a project: Restricted Project. · View Herald TranscriptOct 29 2022, 8:55 AM
Herald added subscribers: mstorsjo, arphaman, arichardson. · View Herald Transcript
Harbormaster completed remote builds in B195094: Diff 471754.Oct 29 2022, 9:22 AM
Mordante updated this revision to Diff 471761.Oct 29 2022, 11:05 AM

CI fixes.

Harbormaster completed remote builds in B195099: Diff 471761.Oct 29 2022, 11:33 AM
Mordante updated this revision to Diff 473414.Nov 5 2022, 3:48 AM

CI fixes and more tests.

Harbormaster completed remote builds in B196279: Diff 473414.Nov 5 2022, 4:19 AM
Mordante updated this revision to Diff 473422.Nov 5 2022, 5:51 AM

Rebased and more CI fixes.

Harbormaster completed remote builds in B196286: Diff 473422.Nov 5 2022, 6:39 AM
Mordante updated this revision to Diff 473497.Nov 6 2022, 6:29 AM

CI fixes.

Harbormaster completed remote builds in B196350: Diff 473497.Nov 6 2022, 7:00 AM
Mordante updated this revision to Diff 473499.Nov 6 2022, 7:39 AM

CI fixes.

Harbormaster completed remote builds in B196352: Diff 473499.Nov 6 2022, 8:08 AM
Mordante updated this revision to Diff 473503.Nov 6 2022, 10:00 AM

CI fixes.

Harbormaster completed remote builds in B196354: Diff 473503.Nov 6 2022, 10:27 AM
Mordante updated this revision to Diff 473505.Nov 6 2022, 11:07 AM

CI fixes.

Harbormaster completed remote builds in B196356: Diff 473505.Nov 6 2022, 11:36 AM
Mordante updated this revision to Diff 479827.Dec 3 2022, 4:18 AM

Rebased, polishing, and improving tests.

Harbormaster completed remote builds in B200906: Diff 479827.Dec 3 2022, 4:46 AM
Mordante updated this revision to Diff 479829.Dec 3 2022, 4:49 AM

CI fixes.

Mordante updated this revision to Diff 479833.Dec 3 2022, 5:08 AM

CI fixes.

Mordante updated this revision to Diff 479834.Dec 3 2022, 5:26 AM

CI fixes.

Harbormaster completed remote builds in B200913: Diff 479834.Dec 3 2022, 5:53 AM
Mordante updated this revision to Diff 479848.Dec 3 2022, 9:49 AM

Add more tests.

Mordante updated this revision to Diff 479851.Dec 3 2022, 10:14 AM

CI fixes

Mordante updated this revision to Diff 479852.Dec 3 2022, 10:40 AM

CI fixes.

Harbormaster completed remote builds in B200923: Diff 479851.Dec 3 2022, 10:42 AM
Mordante updated this revision to Diff 479853.Dec 3 2022, 10:50 AM

Trigger CI.

Mordante updated this revision to Diff 479855.Dec 3 2022, 11:12 AM

Reenable complete XI.

Harbormaster completed remote builds in B200927: Diff 479855.Dec 3 2022, 11:43 AM
Mordante updated this revision to Diff 479859.Dec 3 2022, 11:47 AM

CI fixes.

Harbormaster completed remote builds in B200931: Diff 479859.Dec 3 2022, 12:33 PM
Mordante updated this revision to Diff 479907.Dec 4 2022, 2:09 AM

CI fixes.

Harbormaster completed remote builds in B200963: Diff 479907.Dec 4 2022, 3:26 AM
Mordante edited the summary of this revision. (Show Details)Dec 4 2022, 4:44 AM
Mordante updated this revision to Diff 479914.Dec 4 2022, 4:47 AM

CI fixes.

Harbormaster completed remote builds in B200967: Diff 479914.Dec 4 2022, 6:34 AM
Mordante updated this revision to Diff 479926.Dec 4 2022, 8:24 AM

Rebased and CI fixes.

Harbormaster completed remote builds in B200979: Diff 479926.Dec 4 2022, 11:11 AM
Mordante updated this revision to Diff 480181.Dec 5 2022, 11:44 AM

CI fixes.

Harbormaster completed remote builds in B201173: Diff 480181.Dec 5 2022, 12:08 PM
Mordante updated this revision to Diff 480200.Dec 5 2022, 12:12 PM

CI fixes.

Harbormaster completed remote builds in B201186: Diff 480200.Dec 5 2022, 6:10 PM
Mordante updated this revision to Diff 480495.Dec 6 2022, 8:09 AM

CI fixes.

Mordante updated this revision to Diff 480561.Dec 6 2022, 11:29 AM

Remove debug code.

Harbormaster completed remote builds in B201445: Diff 480561.Dec 6 2022, 7:12 PM
Mordante updated this revision to Diff 481318.Dec 8 2022, 9:05 AM

Rebased and polishing.

Mordante published this revision for review.Dec 8 2022, 12:01 PM
Mordante added inline comments.
libcxx/include/atomic
2656

These are removed due to breakage see https://buildkite.com/llvm-project/libcxx-ci/builds/15514#0184ddf6-ad35-496a-8808-4b35ec626653

chrono does not affect C++03 so not listed in the release notes.

Herald added a project: Restricted Project. · View Herald TranscriptDec 8 2022, 12:01 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B202001: Diff 481318.Dec 8 2022, 4:26 PM
Mordante added a child revision: D139771: [libc++][chrono] Add hh_mm_ss formatter..Dec 10 2022, 3:30 AM
ldionne accepted this revision.Dec 21 2022, 12:37 PM
ldionne added a subscriber: ldionne.
ldionne added inline comments.
libcxx/include/__chrono/convert_to_tm.h
43

Otherwise, it's too likely to become out of date.

47

Do you have a test that would fail if we had that bug?

Answer: yes, it seems you ran into that bug.

libcxx/include/__chrono/formatter.h
586–587

I would remove this from the code since it's just a personal note.

libcxx/include/__chrono/ostream.h
165
libcxx/include/atomic
2656

I don't understand this. Especially since that CI run contains XPASSes, not failures. In other words, it seems like whatever change that was, it actually fixed some tests.

Thanks for explaining, we were mis-detecting the non-lockfree-atomics Lit feature.

libcxx/test/std/time/time.cal/time.cal.md/time.cal.md.nonmembers/ostream.pass.cpp
78

Is this a leftover?

This revision is now accepted and ready to land.Dec 21 2022, 12:37 PM
Mordante marked 4 inline comments as done.Dec 24 2022, 4:04 AM

Thanks for the review!

libcxx/test/std/time/time.cal/time.cal.md/time.cal.md.nonmembers/ostream.pass.cpp
78

No it's something that looks like a bug in the Standard. I have improved the comment.

Mordante updated this revision to Diff 485194.Dec 24 2022, 4:06 AM
Mordante marked an inline comment as done.

Rebased and addresses review comments, just a test before landing.

Harbormaster completed remote builds in B204844: Diff 485194.Dec 24 2022, 6:10 AM
Closed by commit rG105fef5dca7e: [libc++][chrono] Add calendar type formatters. (authored by Mordante). · Explain WhyDec 24 2022, 6:11 AM
This revision was automatically updated to reflect the committed changes.
Mordante added a commit: rG105fef5dca7e: [libc++][chrono] Add calendar type formatters..

Revision Contents
Changeset List

PathSize
libcxx/
docs/
1 line
Status/
24 lines
include/
__chrono/
61 lines
275 lines
93 lines
13 lines
__format/
24 lines
4 lines
53 lines
4 lines
test/
libcxx/
transitive_includes/
7 lines
7 lines
7 lines
7 lines
std/
time/
time.cal/
time.cal.md/
time.cal.md.nonmembers/
134 lines
time.cal.mdlast/
179 lines
time.cal.mwd/
time.cal.mwd.nonmembers/
285 lines
time.cal.mwdlast/
time.cal.mwdlast.nonmembers/
276 lines
time.cal.wdidx/
time.cal.wdidx.nonmembers/
136 lines
time.cal.wdlast/
time.cal.wdlast.nonmembers/
122 lines
time.cal.ym/
time.cal.ym.nonmembers/
249 lines
time.cal.ymd/
time.cal.ymd.nonmembers/
149 lines
time.cal.ymdlast/
time.cal.ymdlast.nonmembers/
266 lines
time.cal.ymwd/
time.cal.ymwd.nonmembers/
251 lines
time.cal.ymwdlast/
time.cal.ymwdlast.nonmembers/
185 lines
time.syn/
489 lines
403 lines
721 lines
410 lines
311 lines
288 lines
1080 lines
932 lines
735 lines
246 lines
utilities/
format/
format.formattable/
26 lines

Diff 485199

View Options

libcxx/docs/ReleaseNotes.rst

Loading...
View Options

libcxx/docs/Status/FormatPaper.csv

Loading...
View Options

libcxx/include/__chrono/convert_to_tm.h

Loading...
View Options

libcxx/include/__chrono/formatter.h

Loading...
View Options

libcxx/include/__chrono/ostream.h

Loading...
View Options

libcxx/include/__chrono/parser_std_format_spec.h

Loading...
View Options

libcxx/include/__format/parser_std_format_spec.h

Loading...
View Options

libcxx/include/atomic

Loading...
View Options

libcxx/include/chrono

Loading...
View Options

libcxx/include/optional

Loading...
View Options

libcxx/test/libcxx/transitive_includes/cxx03.csv

Loading...
View Options

libcxx/test/libcxx/transitive_includes/cxx11.csv

Loading...
View Options

libcxx/test/libcxx/transitive_includes/cxx14.csv

Loading...
View Options

libcxx/test/libcxx/transitive_includes/cxx17.csv

Loading...
View Options

libcxx/test/std/time/time.cal/time.cal.md/time.cal.md.nonmembers/ostream.pass.cpp

Loading...
View Options

libcxx/test/std/time/time.cal/time.cal.mdlast/ostream.pass.cpp

Loading...
View Options

libcxx/test/std/time/time.cal/time.cal.mwd/time.cal.mwd.nonmembers/ostream.pass.cpp

Loading...
View Options

libcxx/test/std/time/time.cal/time.cal.mwdlast/time.cal.mwdlast.nonmembers/ostream.pass.cpp

Loading...
View Options

libcxx/test/std/time/time.cal/time.cal.wdidx/time.cal.wdidx.nonmembers/ostream.pass.cpp

Loading...
View Options

libcxx/test/std/time/time.cal/time.cal.wdlast/time.cal.wdlast.nonmembers/ostream.pass.cpp

Loading...
View Options

libcxx/test/std/time/time.cal/time.cal.ym/time.cal.ym.nonmembers/ostream.pass.cpp

Loading...
View Options

libcxx/test/std/time/time.cal/time.cal.ymd/time.cal.ymd.nonmembers/ostream.pass.cpp

Loading...
View Options

libcxx/test/std/time/time.cal/time.cal.ymdlast/time.cal.ymdlast.nonmembers/ostream.pass.cpp

Loading...
View Options

libcxx/test/std/time/time.cal/time.cal.ymwd/time.cal.ymwd.nonmembers/ostream.pass.cpp

Loading...
View Options

libcxx/test/std/time/time.cal/time.cal.ymwdlast/time.cal.ymwdlast.nonmembers/ostream.pass.cpp

Loading...
View Options

libcxx/test/std/time/time.syn/formatter.month_day.pass.cpp

Loading...
View Options

libcxx/test/std/time/time.syn/formatter.month_day_last.pass.cpp

Loading...
View Options

libcxx/test/std/time/time.syn/formatter.month_weekday.pass.cpp

Loading...
View Options

libcxx/test/std/time/time.syn/formatter.weekday_index.pass.cpp

Loading...
View Options

libcxx/test/std/time/time.syn/formatter.weekday_last.pass.cpp

Loading...
View Options

libcxx/test/std/time/time.syn/formatter.year_month.pass.cpp

Loading...
View Options

libcxx/test/std/time/time.syn/formatter.year_month_day.pass.cpp

Loading...
View Options

libcxx/test/std/time/time.syn/formatter.year_month_day_last.pass.cpp

Loading...
View Options

libcxx/test/std/time/time.syn/formatter.year_month_weekday.pass.cpp

Loading...
View Options

libcxx/test/std/time/time.syn/formatter.year_month_weekday_last.pass.cpp

Loading...
View Options

libcxx/test/std/utilities/format/format.formattable/concept.formattable.compile.pass.cpp

Loading...