This is an archive of the discontinued LLVM Phabricator instance.

Differential D136837

[llvm-debuginfo-analyzer] (08/09) - ELF Reader - Test case (Undefined symbol - multistage)
ClosedPublic

Authored by CarlosAlbertoEnciso on Oct 27 2022, 4:29 AM.

Details

Reviewers
jryans
Commits
rG1f9ef3996814: [llvm-debuginfo-analyzer] (08/09) - ELF Reader
Summary

The fix for the unitest case introduced a dependency on the
MC library causing a failure in:

https://lab.llvm.org/buildbot/#/builders/121/builds/24567
clang-ppc64le-multistage/stage1
undefined reference to symbol 'llvm::TargetRegistry::lookupTarget'

Added:

  • MC to the LLVM_LINK_COMPONENTS list.

Diff Detail

Event Timeline

CarlosAlbertoEnciso created this revision.Oct 27 2022, 4:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 27 2022, 4:29 AM
Herald added subscribers: manas, ASDenysPetrov, dkrupp and 4 others. · View Herald Transcript
CarlosAlbertoEnciso requested review of this revision.Oct 27 2022, 4:29 AM
Herald added a subscriber: llvm-commits. · View Herald TranscriptOct 27 2022, 4:29 AM
CarlosAlbertoEnciso mentioned this in D136825: llvm-debuginfo-analyzer] (08/09) - ELF Reader - - Test case (No available targets).Oct 27 2022, 4:32 AM
jryans accepted this revision.Oct 27 2022, 5:00 AM

Makes sense, thanks! 🙂

This revision is now accepted and ready to land.Oct 27 2022, 5:00 AM
This revision was landed with ongoing or failed builds.Oct 27 2022, 5:06 AM
Closed by commit rG1f9ef3996814: [llvm-debuginfo-analyzer] (08/09) - ELF Reader (authored by CarlosAlbertoEnciso). · Explain Why
This revision was automatically updated to reflect the committed changes.
CarlosAlbertoEnciso added a commit: rG1f9ef3996814: [llvm-debuginfo-analyzer] (08/09) - ELF Reader.
Harbormaster completed remote builds in B194622: Diff 471116.Oct 27 2022, 6:20 AM
CarlosAlbertoEnciso added a comment.Oct 27 2022, 6:21 AM
In D136837#3888191, @jryans wrote:

Makes sense, thanks! 🙂

@jryans The failure has been fixed. https://lab.llvm.org/buildbot/#/builders/121/builds/24575
Once again thanks very much for your valuable reviews.

Revision Contents

PathSize
llvm/
unittests/
DebugInfo/
LogicalView/
1 line

Diff 471116

llvm/unittests/DebugInfo/LogicalView/CMakeLists.txt

Context not available.
AllTargetsInfos AllTargetsInfos
AllTargetsDisassemblers AllTargetsDisassemblers
DebugInfoLogicalView DebugInfoLogicalView
MC
MCDisassembler MCDisassembler
) )
Context not available.