To address unresolved comments in D136185
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
| mlir/include/mlir/Dialect/SparseTensor/Utils/Merger.h | ||
|---|---|---|
| 250 | I just noticed that the i and t appear in reverse order here, would you mind fixing that so all orders are consistent | |
| 260–261 | same request on ordering here | |
| 261 | Would you mind moving the geDimNum methods *after* the setDimLevelType, so that getDimLevelType and getDimLevelType remain grouped together | |
rebase
| mlir/include/mlir/Dialect/SparseTensor/Utils/Merger.h | ||
|---|---|---|
| 261 | but setDimLevelType also set DimNum I changed setDimLevelType to setDimAndDimLevelType, does it look better to you? | |
I just noticed that the i and t appear in reverse order here, would you mind fixing that so all orders are consistent