This is an archive of the discontinued LLVM Phabricator instance.

Differential D136739

[mlir][spirv] more reasonable default for flag mapMemorySpace
ClosedPublic

Authored by jackalcooper on Oct 25 2022, 10:56 PM.

Details

Reviewers
antiagainst
ThomasRaoux
herhut
Commits
rG5fcf3e8b4e90: [mlir][spirv] Flip createConvertGPUToSPIRVPass mapMemorySpace default
Summary

Some down-stream libraries only have access to CAPI, setting default value of mapMemorySpace to false (used in tests) will help them convert IR to SPIRV.

Diff Detail

Event Timeline

jackalcooper created this revision.Oct 25 2022, 10:56 PM
Herald added a reviewer: ThomasRaoux. · View Herald TranscriptOct 25 2022, 10:56 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: zero9178, bzcheeseman, sdasgup3 and 20 others. · View Herald Transcript
jackalcooper requested review of this revision.Oct 25 2022, 10:56 PM
Herald added a reviewer: herhut. · View Herald TranscriptOct 25 2022, 10:56 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
jackalcooper set the repository for this revision to rG LLVM Github Monorepo.Oct 25 2022, 10:56 PM
jackalcooper edited the summary of this revision. (Show Details)
jackalcooper edited the summary of this revision. (Show Details)Oct 25 2022, 11:20 PM
jackalcooper edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B194343: Diff 470717.Oct 25 2022, 11:33 PM
antiagainst accepted this revision.Oct 26 2022, 8:00 AM
This revision is now accepted and ready to land.Oct 26 2022, 8:00 AM
Closed by commit rG5fcf3e8b4e90: [mlir][spirv] Flip createConvertGPUToSPIRVPass mapMemorySpace default (authored by jackalcooper, committed by antiagainst). · Explain WhyOct 26 2022, 8:10 AM
This revision was automatically updated to reflect the committed changes.
antiagainst added a commit: rG5fcf3e8b4e90: [mlir][spirv] Flip createConvertGPUToSPIRVPass mapMemorySpace default.

Revision Contents

PathSize
mlir/
include/
mlir/
Conversion/
GPUToSPIRV/
2 lines

Diff 470820

mlir/include/mlir/Conversion/GPUToSPIRV/GPUToSPIRVPass.h

Show All 23 Lines
#define GEN_PASS_DECL_CONVERTGPUTOSPIRV #define GEN_PASS_DECL_CONVERTGPUTOSPIRV
#include "mlir/Conversion/Passes.h.inc" #include "mlir/Conversion/Passes.h.inc"
/// Creates a pass to convert GPU kernel ops to corresponding SPIR-V ops. For a /// Creates a pass to convert GPU kernel ops to corresponding SPIR-V ops. For a
/// gpu.func to be converted, it should have a spirv.entry_point_abi attribute. /// gpu.func to be converted, it should have a spirv.entry_point_abi attribute.
/// If `mapMemorySpace` is true, performs MemRef memory space to SPIR-V mapping /// If `mapMemorySpace` is true, performs MemRef memory space to SPIR-V mapping
/// according to default Vulkan rules first. /// according to default Vulkan rules first.
std::unique_ptr<OperationPass<ModuleOp>> std::unique_ptr<OperationPass<ModuleOp>>
createConvertGPUToSPIRVPass(bool mapMemorySpace = false); createConvertGPUToSPIRVPass(bool mapMemorySpace = true);
} // namespace mlir } // namespace mlir
#endif // MLIR_CONVERSION_GPUTOSPIRV_GPUTOSPIRVPASS_H #endif // MLIR_CONVERSION_GPUTOSPIRV_GPUTOSPIRVPASS_H