[mlir][sparse] fix bufferizableOpInterface for InsertOp

[Peiming]

Summary

Address comments in D136372

[aartbik]

Thanks Matthias!

[Peiming]

rebase.

mlir/lib/Dialect/SparseTensor/Transforms/BufferizableOpInterfaceImpl.cpp

struct NewOpInterface
   bool bufferizesToAllocation(Operation *op, OpResult opResult) const {
     return true;
   }
 };
 
 struct InsertOpInterface
     : public BufferizableOpInterface::ExternalModel<InsertOpInterface,
                                                     sparse_tensor::InsertOp> {
-  bool bufferizesToAllocation(Operation *op, OpResult opResult) const {
-    // Does bufferization handle realloc?
-    return false;
-  }
-
   bool bufferizesToMemoryRead(Operation *op, OpOperand &opOperand,
                               const AnalysisState &state) const {
-    return false;
+    return true;
   }
 
   bool bufferizesToMemoryWrite(Operation *op, OpOperand &opOperand,
                                const AnalysisState &state) const {
     // InsertOp writes to memory.
     return true;
   }
 
   SmallVector<OpResult> getAliasingOpResult(Operation *op, OpOperand &opOperand,
                                             const AnalysisState &state) const {
     // InsertOp returns an alias of its operand.
     assert(op->getNumResults() == 1);
     return op->getResults();
   }
 
   BufferRelation bufferRelation(Operation *oo, OpResult opResult,
                                 const AnalysisState &state) const {
     // InsertOp returns the same object (realloc should not invalidate
     // aliases).
     return BufferRelation::Equivalent;
   }
-
-  bool isWritable(Operation *op, Value value,
-                  const AnalysisState &state) const {
-    return true;
-  }
 };
 
 } // namespace
 } // namespace sparse_tensor
 } // namespace mlir
 
 void mlir::sparse_tensor::registerBufferizableOpInterfaceExternalModels(
     DialectRegistry &registry) {
   registry.addExtension(
       +[](MLIRContext *ctx, sparse_tensor::SparseTensorDialect *dialect) {
         sparse_tensor::ConvertOp::attachInterface<ConvertOpInterface>(*ctx);
         sparse_tensor::LoadOp::attachInterface<LoadOpInterface>(*ctx);
         sparse_tensor::NewOp::attachInterface<NewOpInterface>(*ctx);
         sparse_tensor::InsertOp::attachInterface<InsertOpInterface>(*ctx);
       });
 }