This is an archive of the discontinued LLVM Phabricator instance.

Update links to googletest documentation
ClosedPublic

Authored by DerKasper on Oct 21 2022, 12:33 AM.

Details

Summary

Update links to googletest documentation
No automatic tests, but local manual test: i click it, it opens the googletest documentation.

Diff Detail

Event Timeline

DerKasper created this revision.Oct 21 2022, 12:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 21 2022, 12:33 AM
DerKasper requested review of this revision.Oct 21 2022, 12:33 AM
sylvestre.ledru accepted this revision.Oct 21 2022, 12:53 AM
sylvestre.ledru added a subscriber: sylvestre.ledru.

Thanks for carrying about the doc!

This revision is now accepted and ready to land.Oct 21 2022, 12:53 AM

Thanks for carrying about the doc!

I am so happy about the functionality of clang and all the tools around, that this is a nice form of giving back something.

I am not sure, what i have to do now, after this was accepted?
In the documentation i find:
"If you do not have commit access, please let people know during the review and someone should commit it on your behalf."

> I strongly believe i have no commit access but forgot to mention that in the review.

np, let me land this for you

I am not sure, what i have to do now, after this was accepted?
In the documentation i find:
"If you do not have commit access, please let people know during the review and someone should commit it on your behalf."

> I strongly believe i have no commit access but forgot to mention that in the review.

Thanks for letting us know! What name and email address would you like us to use for patch attribution when we land the patch?

This revision was automatically updated to reflect the committed changes.

oh, crappy, i forgot to update the author of the patch :(
really sorry about that... :(

oh, crappy, i forgot to update the author of the patch :(
really sorry about that... :(

No worries, it happens (I've made the same mistake a few times as well)! If @DerKasper would appreciate the attribution, they can ask and we can revert and re-land.

yeah, happy to do that if the author wants :)

No worries and no need to waste time with redoing stuff. I can live without all the fame and perks that come with this highly complex contribiution! ;)

ouf, thanks :)

I am sure the doc has plenty of other issues!