Update links to googletest documentation

[DerKasper]

Summary

Update links to googletest documentation
No automatic tests, but local manual test: i click it, it opens the googletest documentation.

[sylvestre.ledru]

Thanks for carrying about the doc!

[DerKasper]

In D136424#3873635, @sylvestre.ledru wrote:

Thanks for carrying about the doc!

I am so happy about the functionality of clang and all the tools around, that this is a nice form of giving back something.

I am not sure, what i have to do now, after this was accepted?
In the documentation i find:
"If you do not have commit access, please let people know during the review and someone should commit it on your behalf."

> I strongly believe i have no commit access but forgot to mention that in the review.

[sylvestre.ledru]

np, let me land this for you

[aaron.ballman]

In D136424#3874180, @DerKasper wrote:

I am not sure, what i have to do now, after this was accepted?
In the documentation i find:
"If you do not have commit access, please let people know during the review and someone should commit it on your behalf."

> I strongly believe i have no commit access but forgot to mention that in the review.

Thanks for letting us know! What name and email address would you like us to use for patch attribution when we land the patch?

[sylvestre.ledru]

pushed

[sylvestre.ledru]

oh, crappy, i forgot to update the author of the patch :(
really sorry about that... :(

[aaron.ballman]

In D136424#3874196, @sylvestre.ledru wrote:

oh, crappy, i forgot to update the author of the patch :(
really sorry about that... :(

No worries, it happens (I've made the same mistake a few times as well)! If @DerKasper would appreciate the attribution, they can ask and we can revert and re-land.

[sylvestre.ledru]

yeah, happy to do that if the author wants :)

[DerKasper]

No worries and no need to waste time with redoing stuff. I can live without all the fame and perks that come with this highly complex contribiution! ;)

[sylvestre.ledru]

ouf, thanks :)

I am sure the doc has plenty of other issues!

clang-tools-extra/clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.h

 #include "../ClangTidyCheck.h"
 
 namespace clang {
 namespace tidy {
 namespace google {
 namespace readability {
 
 // Check for underscores in the names of googletest tests, per
-// https://github.com/google/googletest/blob/master/docs/faq.md#why-should-test-suite-names-and-test-names-not-contain-underscore
+// https://google.github.io/googletest/faq.html#why-should-test-suite-names-and-test-names-not-contain-underscore
 ///
 /// For the user-facing documentation see:
 /// http://clang.llvm.org/extra/clang-tidy/checks/google/readability-avoid-underscore-in-googletest-name.html
 class AvoidUnderscoreInGoogletestNameCheck : public ClangTidyCheck {
 public:
   using ClangTidyCheck::ClangTidyCheck;
 
   void registerPPCallbacks(const SourceManager &SM, Preprocessor *PP,

clang-tools-extra/docs/clang-tidy/checks/google/readability-avoid-underscore-in-googletest-name.rst

 case names.
 
 The ``DISABLED_`` prefix, which may be used to `disable individual tests`_, is
 ignored when checking test names, but the rest of the rest of the test name is
 still checked.
 
 This check does not propose any fixes.
 
-.. _Underscores are not allowed: https://github.com/google/googletest/blob/master/googletest/docs/faq.md#why-should-test-suite-names-and-test-names-not-contain-underscore
-.. _disable individual tests: https://github.com/google/googletest/blob/master/googletest/docs/faq.md#why-should-test-suite-names-and-test-names-not-contain-underscore
+.. _Underscores are not allowed: https://google.github.io/googletest/faq.html#why-should-test-suite-names-and-test-names-not-contain-underscore
+.. _disable individual tests: https://google.github.io/googletest/advanced.html#temporarily-disabling-tests