This is an archive of the discontinued LLVM Phabricator instance.

Differential D136414

[mlir][Pass] Fix parsePassPipeline error stream
ClosedPublic

Authored by rkayaith on Oct 20 2022, 7:53 PM.

Details

Reviewers
rriddle
Commits
rG037804ddb396: [mlir][Pass] Fix parsePassPipeline error stream
Summary

The error stream isn't being propagated properly, causing some output to
be sent to stderr even when a different stream is given.

Diff Detail

Event Timeline

rkayaith created this revision.Oct 20 2022, 7:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 20 2022, 7:53 PM
Herald added subscribers: zero9178, bzcheeseman, sdasgup3 and 18 others. · View Herald Transcript
rkayaith requested review of this revision.Oct 20 2022, 7:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 20 2022, 7:53 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B193410: Diff 469455.Oct 20 2022, 8:07 PM
rriddle accepted this revision.Oct 21 2022, 10:00 AM
This revision is now accepted and ready to land.Oct 21 2022, 10:00 AM
Closed by commit rG037804ddb396: [mlir][Pass] Fix parsePassPipeline error stream (authored by rkayaith). · Explain WhyOct 21 2022, 11:26 AM
This revision was automatically updated to reflect the committed changes.
rkayaith added a commit: rG037804ddb396: [mlir][Pass] Fix parsePassPipeline error stream.

Revision Contents

PathSize
mlir/
lib/
Pass/
5 lines

Diff 469455

mlir/lib/Pass/PassRegistry.cpp

Show First 20 Lines • Show All 693 Lines • ▼ Show 20 Lines
FailureOr<OpPassManager> mlir::parsePassPipeline(StringRef pipeline, FailureOr<OpPassManager> mlir::parsePassPipeline(StringRef pipeline,
raw_ostream &errorStream) { raw_ostream &errorStream) {
// Pipelines are expected to be of the form `<op-name>(<pipeline>)`. // Pipelines are expected to be of the form `<op-name>(<pipeline>)`.
size_t pipelineStart = pipeline.find_first_of('('); size_t pipelineStart = pipeline.find_first_of('(');
if (pipelineStart == 0 || pipelineStart == StringRef::npos || if (pipelineStart == 0 || pipelineStart == StringRef::npos ||
!pipeline.consume_back(")")) { !pipeline.consume_back(")")) {
errorStream << "expected pass pipeline to be wrapped with the anchor " errorStream << "expected pass pipeline to be wrapped with the anchor "
"operation type, e.g. `builtin.module(...)"; "operation type, e.g. 'builtin.module(...)'";
return failure(); return failure();
} }
StringRef opName = pipeline.take_front(pipelineStart); StringRef opName = pipeline.take_front(pipelineStart);
OpPassManager pm(opName); OpPassManager pm(opName);
if (failed(parsePassPipeline(pipeline.drop_front(1 + pipelineStart), pm))) if (failed(parsePassPipeline(pipeline.drop_front(1 + pipelineStart), pm,
errorStream)))
return failure(); return failure();
return pm; return pm;
} }
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// PassNameParser // PassNameParser
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
▲ Show 20 Lines • Show All 248 Lines • Show Last 20 Lines