This is an archive of the discontinued LLVM Phabricator instance.

Differential D136062

[AArch64] Make ACLE intrinsics always available part MTE
ClosedPublic

Authored by danielkiss on Oct 17 2022, 3:09 AM.

Details

Reviewers
dmgreen
eugenis
Commits
rG0d0ca64356ff: [AArch64] Make ACLE intrinsics always available part MTE
rG09aaf190d933: [AArch64] Make ACLE intrinsics always available part MTE
Summary

Make MTE intrinsics available in function scope too.
Followup from D133359.

Diff Detail

Event Timeline

danielkiss created this revision.Oct 17 2022, 3:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 17 2022, 3:09 AM
Herald added a subscriber: kristof.beyls. · View Herald Transcript
danielkiss requested review of this revision.Oct 17 2022, 3:09 AM
Harbormaster completed remote builds in B192454: Diff 468143.Oct 17 2022, 3:53 AM
dmgreen added a comment.Oct 17 2022, 8:10 AM

Could we add quick a test for when the intrinsics give an error due to insufficient features, and maybe show it works OK with a __attribute((target(..)))?

Allen added a subscriber: Allen.Oct 17 2022, 8:11 AM
danielkiss updated this revision to Diff 468265.Oct 17 2022, 11:16 AM

adding test

eugenis added a comment.Oct 17 2022, 11:17 AM

I like the direction of this change and agree that it needs a test.

eugenis added a comment.Oct 17 2022, 11:20 AM

LGTM

Harbormaster completed remote builds in B192542: Diff 468265.Oct 17 2022, 12:06 PM
dmgreen accepted this revision.Oct 18 2022, 12:26 AM

Thanks - LGTM

This revision is now accepted and ready to land.Oct 18 2022, 12:26 AM
This revision was landed with ongoing or failed builds.Oct 18 2022, 1:36 AM
Closed by commit rG09aaf190d933: [AArch64] Make ACLE intrinsics always available part MTE (authored by danielkiss). · Explain Why
This revision was automatically updated to reflect the committed changes.
danielkiss added a commit: rG09aaf190d933: [AArch64] Make ACLE intrinsics always available part MTE.
Herald added a project: Restricted Project. · View Herald TranscriptOct 18 2022, 1:36 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
danielkiss added a reverting change: rGa175d8b1772f: Revert "[AArch64] Make ACLE intrinsics always available part MTE".Oct 18 2022, 1:46 AM
danielkiss added a commit: rG0d0ca64356ff: [AArch64] Make ACLE intrinsics always available part MTE.Oct 18 2022, 2:03 AM

Revision Contents

PathSize
clang/
include/
clang/
Basic/
14 lines
lib/
Headers/
4 lines

Diff 468143

clang/include/clang/Basic/BuiltinsAArch64.def

Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Lines
TARGET_BUILTIN(__builtin_arm_crc32h, "UiUiUs", "nc", "crc") TARGET_BUILTIN(__builtin_arm_crc32h, "UiUiUs", "nc", "crc")
TARGET_BUILTIN(__builtin_arm_crc32ch, "UiUiUs", "nc", "crc") TARGET_BUILTIN(__builtin_arm_crc32ch, "UiUiUs", "nc", "crc")
TARGET_BUILTIN(__builtin_arm_crc32w, "UiUiUi", "nc", "crc") TARGET_BUILTIN(__builtin_arm_crc32w, "UiUiUi", "nc", "crc")
TARGET_BUILTIN(__builtin_arm_crc32cw, "UiUiUi", "nc", "crc") TARGET_BUILTIN(__builtin_arm_crc32cw, "UiUiUi", "nc", "crc")
TARGET_BUILTIN(__builtin_arm_crc32d, "UiUiWUi", "nc", "crc") TARGET_BUILTIN(__builtin_arm_crc32d, "UiUiWUi", "nc", "crc")
TARGET_BUILTIN(__builtin_arm_crc32cd, "UiUiWUi", "nc", "crc") TARGET_BUILTIN(__builtin_arm_crc32cd, "UiUiWUi", "nc", "crc")
// Memory Tagging Extensions (MTE) // Memory Tagging Extensions (MTE)
BUILTIN(__builtin_arm_irg, "v*v*Ui", "t") TARGET_BUILTIN(__builtin_arm_irg, "v*v*Ui", "t", "mte")
BUILTIN(__builtin_arm_addg, "v*v*Ui", "t") TARGET_BUILTIN(__builtin_arm_addg, "v*v*Ui", "t", "mte")
BUILTIN(__builtin_arm_gmi, "Uiv*Ui", "t") TARGET_BUILTIN(__builtin_arm_gmi, "Uiv*Ui", "t", "mte")
BUILTIN(__builtin_arm_ldg, "v*v*", "t") TARGET_BUILTIN(__builtin_arm_ldg, "v*v*", "t", "mte")
BUILTIN(__builtin_arm_stg, "vv*", "t") TARGET_BUILTIN(__builtin_arm_stg, "vv*", "t", "mte")
BUILTIN(__builtin_arm_subp, "Uiv*v*", "t") TARGET_BUILTIN(__builtin_arm_subp, "Uiv*v*", "t", "mte")
// Memory Operations // Memory Operations
BUILTIN(__builtin_arm_mops_memset_tag, "v*v*iz", "") TARGET_BUILTIN(__builtin_arm_mops_memset_tag, "v*v*iz", "", "mte,mops")
// Memory barrier // Memory barrier
BUILTIN(__builtin_arm_dmb, "vUi", "nc") BUILTIN(__builtin_arm_dmb, "vUi", "nc")
BUILTIN(__builtin_arm_dsb, "vUi", "nc") BUILTIN(__builtin_arm_dsb, "vUi", "nc")
BUILTIN(__builtin_arm_isb, "vUi", "nc") BUILTIN(__builtin_arm_isb, "vUi", "nc")
TARGET_BUILTIN(__builtin_arm_jcvt, "Zid", "nc", "v8.3a") TARGET_BUILTIN(__builtin_arm_jcvt, "Zid", "nc", "v8.3a")
▲ Show 20 Lines • Show All 192 Lines • Show Last 20 Lines

clang/lib/Headers/arm_acle.h

Show First 20 Lines • Show All 716 Lines • ▼ Show 20 Lines
#define __arm_rsrf64(sysreg) __builtin_bit_cast(double, __arm_rsr64(sysreg)) #define __arm_rsrf64(sysreg) __builtin_bit_cast(double, __arm_rsr64(sysreg))
#define __arm_wsr(sysreg, v) __builtin_arm_wsr(sysreg, v) #define __arm_wsr(sysreg, v) __builtin_arm_wsr(sysreg, v)
#define __arm_wsr64(sysreg, v) __builtin_arm_wsr64(sysreg, v) #define __arm_wsr64(sysreg, v) __builtin_arm_wsr64(sysreg, v)
#define __arm_wsrp(sysreg, v) __builtin_arm_wsrp(sysreg, v) #define __arm_wsrp(sysreg, v) __builtin_arm_wsrp(sysreg, v)
#define __arm_wsrf(sysreg, v) __arm_wsr(sysreg, __builtin_bit_cast(uint32_t, v)) #define __arm_wsrf(sysreg, v) __arm_wsr(sysreg, __builtin_bit_cast(uint32_t, v))
#define __arm_wsrf64(sysreg, v) __arm_wsr64(sysreg, __builtin_bit_cast(uint64_t, v)) #define __arm_wsrf64(sysreg, v) __arm_wsr64(sysreg, __builtin_bit_cast(uint64_t, v))
/* Memory Tagging Extensions (MTE) Intrinsics */ /* Memory Tagging Extensions (MTE) Intrinsics */
#if defined(__ARM_FEATURE_MEMORY_TAGGING) && __ARM_FEATURE_MEMORY_TAGGING #if defined(__ARM_64BIT_STATE) && __ARM_64BIT_STATE
#define __arm_mte_create_random_tag(__ptr, __mask) __builtin_arm_irg(__ptr, __mask) #define __arm_mte_create_random_tag(__ptr, __mask) __builtin_arm_irg(__ptr, __mask)
#define __arm_mte_increment_tag(__ptr, __tag_offset) __builtin_arm_addg(__ptr, __tag_offset) #define __arm_mte_increment_tag(__ptr, __tag_offset) __builtin_arm_addg(__ptr, __tag_offset)
#define __arm_mte_exclude_tag(__ptr, __excluded) __builtin_arm_gmi(__ptr, __excluded) #define __arm_mte_exclude_tag(__ptr, __excluded) __builtin_arm_gmi(__ptr, __excluded)
#define __arm_mte_get_tag(__ptr) __builtin_arm_ldg(__ptr) #define __arm_mte_get_tag(__ptr) __builtin_arm_ldg(__ptr)
#define __arm_mte_set_tag(__ptr) __builtin_arm_stg(__ptr) #define __arm_mte_set_tag(__ptr) __builtin_arm_stg(__ptr)
#define __arm_mte_ptrdiff(__ptra, __ptrb) __builtin_arm_subp(__ptra, __ptrb) #define __arm_mte_ptrdiff(__ptra, __ptrb) __builtin_arm_subp(__ptra, __ptrb)
#endif
/* Memory Operations Intrinsics */ /* Memory Operations Intrinsics */
#if defined(__ARM_FEATURE_MOPS) && __ARM_FEATURE_MOPS && defined(__ARM_FEATURE_MEMORY_TAGGING) && __ARM_FEATURE_MEMORY_TAGGING
#define __arm_mops_memset_tag(__tagged_address, __value, __size) \ #define __arm_mops_memset_tag(__tagged_address, __value, __size) \
__builtin_arm_mops_memset_tag(__tagged_address, __value, __size) __builtin_arm_mops_memset_tag(__tagged_address, __value, __size)
#endif #endif
/* Transactional Memory Extension (TME) Intrinsics */ /* Transactional Memory Extension (TME) Intrinsics */
#if defined(__ARM_FEATURE_TME) && __ARM_FEATURE_TME #if defined(__ARM_FEATURE_TME) && __ARM_FEATURE_TME
#define _TMFAILURE_REASON 0x00007fffu #define _TMFAILURE_REASON 0x00007fffu
Show All 35 Lines