This is an archive of the discontinued LLVM Phabricator instance.

Differential D135823

[mlir] Update CallInterfaceCallable to use the new casting infra
ClosedPublic

Authored by nkreeger on Oct 12 2022, 3:58 PM.

Details

Reviewers
rriddle
bzcheeseman
lattner
Commits
rGe750c41ec1ac: [mlir] Update CallInterfaceCallable to use the new casting infra.
Summary

This enables casting LLVM style for mlir::CallInterfaceCallable usage.

Diff Detail

Event Timeline

nkreeger created this revision.Oct 12 2022, 3:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 12 2022, 3:58 PM
Herald added subscribers: zero9178, sdasgup3, wenzhicui and 17 others. · View Herald Transcript
nkreeger requested review of this revision.Oct 12 2022, 3:58 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptOct 12 2022, 3:58 PM
rriddle added a comment.Oct 12 2022, 4:00 PM

Can you update the usages to use the new casting infra? There likely aren't many.

lattner accepted this revision.Oct 12 2022, 4:02 PM
lattner added a subscriber: lattner.

Nice Nick, +1 for updating in tree uses if there are any

This revision is now accepted and ready to land.Oct 12 2022, 4:02 PM
Harbormaster completed remote builds in B191835: Diff 467287.Oct 12 2022, 4:55 PM
nkreeger updated this revision to Diff 467346.Oct 12 2022, 7:51 PM

Updated to fix callers with new dyn_cast usage.

Harbormaster completed remote builds in B191880: Diff 467346.Oct 12 2022, 8:16 PM
bzcheeseman accepted this revision.Oct 12 2022, 9:32 PM

Thanks Nick :)

Closed by commit rGe750c41ec1ac: [mlir] Update CallInterfaceCallable to use the new casting infra. (authored by nkreeger). · Explain WhyOct 13 2022, 6:33 PM
This revision was automatically updated to reflect the committed changes.
nkreeger added a commit: rGe750c41ec1ac: [mlir] Update CallInterfaceCallable to use the new casting infra..

Revision Contents

PathSize
mlir/
include/
mlir/
Interfaces/
8 lines

Diff 467287

mlir/include/mlir/Interfaces/CallInterfaces.h

Context not available.
/// Include the generated interface declarations. /// Include the generated interface declarations.
#include "mlir/Interfaces/CallInterfaces.h.inc" #include "mlir/Interfaces/CallInterfaces.h.inc"
namespace llvm {
template <typename To>
struct CastInfo<To, mlir::CallInterfaceCallable>
: public CastInfo<To, mlir::CallInterfaceCallable::PointerUnion> {};
} // namespace llvm
#endif // MLIR_INTERFACES_CALLINTERFACES_H #endif // MLIR_INTERFACES_CALLINTERFACES_H
Context not available.