I think the needed functionality was already implemented for host associations,
so turn that code into a function and move it into a (hopefully appropriate)
common location and reuse it.
Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
Thanks for working on this and identifying the opportunity to re-use some code (I had completely forgotten this was here) !
flang/include/flang/Optimizer/Builder/Character.h | ||
---|---|---|
229 ↗ | (On Diff #466155) | the "Optimizer" part does not depend on semantics (the rational being that it is meant to work from FIR files that will not include any semantics data structures any more). In this case, I think you can just move the helper to https://github.com/llvm/llvm-project/blob/main/flang/include/flang/Lower/Allocatable.h and its cpp files (where it is OK to depends on semantics). |
Comment Actions
Move helper function to Allocatable.h/cpp. Also add lines to pointer tests to check we are reading from the argument to match the allocatable tests.
flang/include/flang/Optimizer/Builder/Character.h | ||
---|---|---|
229 ↗ | (On Diff #466155) | Got it, thanks! The helper has been moved. Thanks for looking over this! |