Page MenuHomePhabricator
Differential D135364

[flang] Add simplified version of minval
Needs ReviewPublic
Actions

Authored by Leporacanthicus on Oct 6 2022, 7:10 AM.

Details

Reviewers
vzakhari
kiranchandramohan
DavidTruby
tblah
Summary

Similar to the maxval function already in place.

Diff Detail

Event Timeline

Leporacanthicus created this revision.Oct 6 2022, 7:10 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptOct 6 2022, 7:10 AM
Herald added a subscriber: mehdi_amini. · View Herald Transcript
Leporacanthicus requested review of this revision.Oct 6 2022, 7:10 AM
Herald added a subscriber: jdoerfert. · View Herald TranscriptOct 6 2022, 7:10 AM
MatsPetersson added reviewers: vzakhari, kiranchandramohan, DavidTruby, tblah.Oct 6 2022, 7:31 AM
Harbormaster completed remote builds in B190725: Diff 465720.Oct 6 2022, 7:37 AM
kiranchandramohan added inline comments.Oct 6 2022, 3:01 PM
flang/lib/Optimizer/Transforms/SimplifyIntrinsics.cpp
274

I guess this can share more code with Maxval.

flang/test/Transforms/simplifyintrinsics.fir
1002

Has this been extended to multi-dimensional arrays like SUM? If so, add a testcase for that as well.

vzakhari added a comment.Oct 10 2022, 1:10 PM

LGTM modulo Kiran's remarks.

Revision Contents
Changeset List

PathSize
flang/
lib/
Optimizer/
Transforms/
33 lines
test/
Transforms/
56 lines

Diff 465720

View Options

flang/lib/Optimizer/Transforms/SimplifyIntrinsics.cpp

Loading...
View Options

flang/test/Transforms/simplifyintrinsics.fir

Loading...