[clang][ExtractAPI] Don't print locations for anonymous tags

[zixuw]

Summary

ExtractAPI doesn't care about locations of anonymous TagDecls. Set the
printing policy to exclude that from anonymous decl names.

[zixuw]

Set PrintingPolicy properly

[ributzka]

This doesn't affect any tests?

[sammccall]

LG from my side assuming you're happy with the strings changing.

In D135295#3837734, @ributzka wrote:

This doesn't affect any tests?

This doesn't affect tests because anonymous decls currently print as the empty string, but will soon print as (unnamed struct at /path/foo.cpp:4:1) without this patch, or (unnamed struct) with this patch.

clang/lib/ExtractAPI/ExtractAPIConsumer.cpp

854

nit: this isn't *just* clearing AnonymousTagLocations, but also resetting any other PP flags to defaults based on LangOpts. You could getPrintingPolicy() instead if you didn't intend to do this.

[zixuw]

In D135295#3837734, @ributzka wrote:

This doesn't affect any tests?

Just finished building locally, running tests to verify now

[zixuw]

clang/lib/ExtractAPI/ExtractAPIConsumer.cpp

854

Makes sense. Probably doesn't matter because I'm pretty sure PrintingPolicy for ExtractAPI is just the default now. Still, good to use getPrintingPolicy to be sure

[zixuw]

Update on top of the existing PrintingPolicy in the ASTContext instead of creating a new default one.

[zixuw]

In D135295#3837855, @zixuw wrote:

In D135295#3837734, @ributzka wrote:

This doesn't affect any tests?

Just finished building locally, running tests to verify now

Doesn't affect any test for this patch as expected. Still need to see how does it interacts with https://reviews.llvm.org/D134813.

[zixuw]

In D135295#3837895, @zixuw wrote:

In D135295#3837855, @zixuw wrote:

In D135295#3837734, @ributzka wrote:

This doesn't affect any tests?

Just finished building locally, running tests to verify now

Doesn't affect any test for this patch as expected. Still need to see how does it interacts with https://reviews.llvm.org/D134813.

Interaction with D134813 looks good. Landing this

clang/lib/ExtractAPI/ExtractAPIConsumer.cpp

API = std::make_unique<APISet>(
       CI.getTarget().getTriple(),
       CI.getFrontendOpts().Inputs.back().getKind().getLanguage());
 
   auto LCF = std::make_unique<LocationFileChecker>(CI, KnownInputFiles);
 
   CI.getPreprocessor().addPPCallbacks(std::make_unique<MacroCallback>(
       CI.getSourceManager(), *LCF, *API, CI.getPreprocessor()));
 
+  // Do not include location in anonymous decls.
+  PrintingPolicy Policy = CI.getASTContext().getPrintingPolicy();
+  Policy.AnonymousTagLocations = false;
+  CI.getASTContext().setPrintingPolicy(Policy);
+
   return std::make_unique<ExtractAPIConsumer>(CI.getASTContext(),
                                               std::move(LCF), *API);
 }
 
 bool ExtractAPIAction::PrepareToExecuteAction(CompilerInstance &CI) {
   auto &Inputs = CI.getFrontendOpts().Inputs;
   if (Inputs.empty())
     return true;