Differential D135147

[GISel] Handle G_TRUNC in `matchExtractVecEltBuildVec`
ClosedPublic
Actions

Authored by Pierre-vh on Oct 4 2022, 4:56 AM.

Tags

Subscribers

Details

Reviewers

arsenm
aemerson

Commits

rGa34977c4d010: [GISel] Handle G_TRUNC in `matchExtractVecEltBuildVec`

Summary

Spotted some cases in D134354 where this was an issue.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	60,070 ms	x64 debian > MLIR.Examples/standalone::test.toy Script: -- : 'RUN: at line 1'; /usr/bin/cmake /var/lib/buildkite-agent/builds/llvm-project/mlir/examples/standalone -G "Ninja" -DCMAKE_CXX_COMPILER=/usr/bin/clang++ -DCMAKE_C_COMPILER=/usr/bin/clang -DLLVM_ENABLE_LIBCXX=OFF -DMLIR_DIR=/var/lib/buildkite-agent/builds/llvm-project/build/lib/cmake/mlir -DLLVM_USE_LINKER=lld -DPython3_EXECUTABLE="/usr/bin/python3.9"

Event Timeline

Pierre-vh created this revision.Oct 4 2022, 4:56 AM

Herald added a project: Restricted Project. · View Herald TranscriptOct 4 2022, 4:56 AM

Herald added a subscriber: hiraditya. · View Herald Transcript

Pierre-vh requested review of this revision.Oct 4 2022, 4:56 AM

Herald added a project: Restricted Project. · View Herald TranscriptOct 4 2022, 4:56 AM

Herald added subscribers: llvm-commits, wdng. · View Herald Transcript

Pierre-vh added a child revision: D134354: [AMDGPU][GlobalISel] Support mad/fma_mix selection.Oct 4 2022, 4:58 AM

Harbormaster completed remote builds in B190174: Diff 464964.Oct 4 2022, 5:49 AM

arsenm added inline comments.Oct 5 2022, 8:46 AM

llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp
3931–3933	I don't see why this legality check (or the one below for build_vector_trunc) are here. The equivalent DAG combine does not check for the legality, and you're not creating a new one in the apply
3941	getVRegDef should be adequate here

Pierre-vh added a reviewer: aemerson.Oct 6 2022, 12:02 AM

getDefIgnoringCopies -> getVRegDef

llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp
3931–3933	@aemerson I see you implemented this one, is it okay to remove the legalizer checks?

aemerson added inline comments.Oct 6 2022, 12:11 AM

llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp
3931–3933	Sure, I don’t remember why it’s there either.

Remove legalizer checks, simplify code

Harbormaster completed remote builds in B190687: Diff 465669.Oct 6 2022, 1:24 AM

arsenm accepted this revision.Oct 6 2022, 8:31 AM

This revision is now accepted and ready to land.Oct 6 2022, 8:31 AM

Closed by commit rGa34977c4d010: [GISel] Handle G_TRUNC in `matchExtractVecEltBuildVec` (authored by Pierre-vh). · Explain WhyOct 7 2022, 1:37 AM

This revision was automatically updated to reflect the committed changes.

Pierre-vh added a commit: rGa34977c4d010: [GISel] Handle G_TRUNC in `matchExtractVecEltBuildVec`.

Revision Contents
Changeset List

Path

Size

llvm/

lib/

CodeGen/

GlobalISel/

CombinerHelper.cpp

27 lines

test/

CodeGen/

AArch64/

GlobalISel/

combine-extract-vec-elt.mir

34 lines

Diff 464964

llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp

Loading...

llvm/test/CodeGen/AArch64/GlobalISel/combine-extract-vec-elt.mir

Loading...