[llvm-objdump] Add --no-addresses as an alias for --no-leading-addr

[MaskRay]

Summary

The output is similar to objdump --no-addresses since binutils 2.35.

Depends on D135039
Close #58088

[jhenderson]

llvm/tools/llvm-objdump/ObjdumpOpts.td

133

Just a quick note: unless something has changed at some point (I don't have a quick way to build and check llvm-objdump currently, or I'd check myself), because this has no help text, I believe it won't appear in the list of options listed by --help. This means that the documentation and the help text won't agree with one another, which seems less than ideal.

[MaskRay]

llvm/tools/llvm-objdump/ObjdumpOpts.td

133

Append , HelpText<"Alias for --no-leading-addr">?

[jhenderson]

llvm/tools/llvm-objdump/ObjdumpOpts.td

133

Yep, that would be in keeping with the surrounding code.

llvm/docs/CommandGuide/llvm-objdump.rst

.. option:: --mcpu=<cpu-name>
   Target a specific CPU type for disassembly. Specify ``--mcpu=help`` to display
   available CPUs.
 
 .. option:: --mattr=<a1,+a2,-a3,...>
 
   Enable/disable target-specific attributes. Specify ``--mattr=help`` to display
   the available attributes.
 
-.. option:: --no-leading-addr
+.. option:: --no-leading-addr, --no-addresses
 
   When disassembling, do not print leading addresses for instructions or inline
   relocations.
 
 .. option:: --no-print-imm-hex
 
   Do not use hex format for immediate values in disassembly output (default).
 

llvm/test/tools/llvm-objdump/X86/elf-disassemble-relocs-exec.test

 ## Check that 'llvm-objdump -dr' correctly prints relocations in executables.
 
 # RUN: yaml2obj --docnum=1 %s -o %t
 # RUN: llvm-objdump -dr %t | FileCheck %s --match-full-lines --strict-whitespace
 # RUN: llvm-objdump -dr --no-leading-addr %t | FileCheck %s --check-prefix=NOADDR --match-full-lines --strict-whitespace
+# RUN: llvm-objdump -dr --no-addresses %t | FileCheck %s --check-prefix=NOADDR --match-full-lines --strict-whitespace
 
 # RUN: yaml2obj -DBITS=32 %s -o %t.32
 # RUN: llvm-objdump -dr --no-leading-addr %t.32 | FileCheck %s --check-prefix=NOADDR --match-full-lines --strict-whitespace
 
 #      CHECK:0000000000400000 <.text>:
 # CHECK-NEXT:  400000: 90                             nop
 # CHECK-NEXT:  400001: bf 10 00 40 00                 movl  $4194320, %edi          # imm = 0x400010
 # CHECK-NEXT:   0000000000400002:  R_X86_64_32  .rodata

llvm/test/tools/llvm-objdump/X86/print-symbol-addr.s

 # ADDR-NEXT:       0: 01 00{{ +}} addl  %eax, (%{{[er]}}ax)
 #ADDR-EMPTY:
 
 ## Check we do not print the addresses with --no-leading-addr.
 # RUN: llvm-objdump -d --no-leading-addr %t.32.o > %t.32.txt
 # RUN: llvm-objdump -d --no-leading-addr %t.64.o > %t.64.txt
 # RUN: FileCheck --input-file=%t.32.txt %s --check-prefix=NOADDR --match-full-lines --strict-whitespace
 # RUN: FileCheck --input-file=%t.64.txt %s --check-prefix=NOADDR --match-full-lines --strict-whitespace
+# RUN: llvm-objdump -d --no-addresses %t.32.o | diff %t.32.txt -
+# RUN: llvm-objdump -d --no-addresses %t.64.o | diff %t.64.txt -
 
 #      NOADDR:<foo>:
 # NOADDR-NEXT: 90{{ +}} nop
 # NOADDR-NEXT: 90{{ +}} nop
 #NOADDR-EMPTY:
 #      NOADDR:<bar>:
 # NOADDR-NEXT: 90{{ +}} nop
 

llvm/tools/llvm-objdump/ObjdumpOpts.td

def mattr_EQ : Joined<["--"], "mattr=">,
   HelpText<"Target specific attributes (--mattr=help for details)">;
 
 def no_show_raw_insn : Flag<["--"], "no-show-raw-insn">,
   HelpText<"When disassembling instructions, "
            "do not print the instruction bytes.">;
 
 def no_leading_addr : Flag<["--"], "no-leading-addr">,
   HelpText<"When disassembling, do not print leading addresses for instructions or inline relocations">;
+def : Flag<["--"], "no-addresses">, Alias<no_leading_addr>;
 
 def raw_clang_ast : Flag<["--"], "raw-clang-ast">,
   HelpText<"Dump the raw binary contents of the clang AST section">;
 
 def reloc : Flag<["--"], "reloc">,
   HelpText<"Display the relocation entries in the file">;
 def : Flag<["-"], "r">, Alias<reloc>, HelpText<"Alias for --reloc">;