Page MenuHomePhabricator

[libunwind] Fix compile error with CROSS_UNWINDING
ClosedPublic

Authored by fmayer on Sep 30 2022, 8:47 AM.

Details

Reviewers
MaskRay
mgorny
Group Reviewers
Restricted Project
Commits
rGf5c9931fefca: [libunwind] Fix compile error with CROSS_UNWINDING

Diff Detail

Event Timeline

fmayer created this revision.Sep 30 2022, 8:47 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptSep 30 2022, 8:47 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
fmayer requested review of this revision.Sep 30 2022, 8:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 30 2022, 8:47 AM
MaskRay accepted this revision.Sep 30 2022, 10:22 AM
This revision is now accepted and ready to land.Sep 30 2022, 10:22 AM
fmayer added a subscriber: compnerd.
mgorny accepted this revision.Sep 30 2022, 11:22 AM

Thanks. I can confirm that it fixes the build.

MaskRay added a comment.EditedSep 30 2022, 11:46 AM

Phabricator doesn't work like other review systems where you use WANT_LGTM=all. There is usually no need to remove a reviewer except a few cases, e.g. a reviewer is apparently not involved in llvm-project for a long time, a reviewer removes themselves from the reviewer list.
Not for this case: sometimes removing a reviewer can be perceived negatively, e.g. whether the patch author wants to bypass someone's opinion.

Phabricator doesn't work like other review systems where you use WANT_LGTM=all. There is usually no need to remove a reviewer except a few cases, e.g. a reviewer is apparently not involved in llvm-project for a long time, a reviewer removes themselves from the reviewer list.
Not for this case: sometimes removing a reviewer can be perceived negatively, e.g. whether the patch author wants to bypass someone's opinion.

This was meant as a signal that I am no longer waiting for or expecting approval from compnerd@

This revision was automatically updated to reflect the committed changes.