[mlir] Use hip's config mode to find libraries

[krzysz00]

Summary

Instead of using find_package(HIP) to find FindHIP.cmake, which
doesn't seem to be the preferred way to find HIP anymore, use
find_package(hip CONFIG) to find the HIP configuration. Give
preference to ${ROCM_PATH} over ${ROCM_PATH}/hip in order to handle
the fact that newer ROCm versions prefer the include path to use
${ROCM_PATH}/include/hip over ${ROCM_PATH}/hip/innclude/hip (the
latter throws up a bunch of deprecation warnings)

Then, instead of trying to manually find the host-side headers and
runtime library by hand, use the hip::host and hip::amdhip64 libraries
that the config module defines.

This makes the CMake config much less error-prone and brings it in
line with the recommended approach to finding HIP.

[arsenm]

mlir/lib/ExecutionEngine/CMakeLists.txt

193

This is a cmake crime, CMAKE_PREFIX_PATH should not be modified. find_package(hip) should know the default location to search

197

Can this use amdgpu-arch from clang instead? That would cut down the number of dependencies to just the hip libraries

[krzysz00]

mlir/lib/ExecutionEngine/CMakeLists.txt

193

Unfortulately, per the latest documentation I was able to find, these CMake crimes are what the HIP documentation tells you to do https://rocmdocs.amd.com/en/latest/Installation_Guide/Using-CMake-with-AMD-ROCm.html .

Also, from memory (I can test this if you'd like), not doing this makes find_package(hip) fail to find its own dependencies because the CMake code for find_package(hip) doesn't set PATHS or HINTS appropriately when it calls find_package(...). So I think this is best viewed as a bug against HIP.

197

Having just tried running amdgpu-arch on a development machine, it segfaulted, while rocm_agent_enumerator worked just fine.

[arsenm]

mlir/lib/ExecutionEngine/CMakeLists.txt

193

Those documents are just wrong. CMAKE_PREFIX_PATH is for users to set on the command line, not for scripts to mess with. find_package hip absolutely must use PATHS and HINTs for the default install location (I know at somepoint someone was working on a very wrong project to remove all of these HINTS and PATHs everywhere that I thought we put a stop to)

[krzysz00]

mlir/lib/ExecutionEngine/CMakeLists.txt

193

From looking at /opt/rocm-5.3.0/lib/cmake/hip/hip-config.cmake on my system ... the find_dependency macro in there doesn't set PATHS or HINTS and so this attempt to stop the project apparently didn't happen.

mlir/lib/ExecutionEngine/CMakeLists.txt

if(MLIR_ENABLE_ROCM_RUNNER)
   # Configure ROCm support.
   if (NOT DEFINED ROCM_PATH)
     if (NOT DEFINED ENV{ROCM_PATH})
       set(ROCM_PATH "/opt/rocm" CACHE PATH "Path to which ROCm has been installed")
     else()
       set(ROCM_PATH $ENV{ROCM_PATH} CACHE PATH "Path to which ROCm has been installed")
     endif()
   endif()
-  set(HIP_PATH "${ROCM_PATH}/hip" CACHE PATH "Path to which HIP has been installed")
-  set(CMAKE_MODULE_PATH "${HIP_PATH}/cmake" ${CMAKE_MODULE_PATH})
-  find_package(HIP)
-  if (NOT HIP_FOUND)
-    message(SEND_ERROR "Building mlir with ROCm support requires a working ROCm and HIP install")
-  else()
-    message(STATUS "ROCm HIP version: ${HIP_VERSION}")
-  endif()
-
-  # Locate HIP runtime library.
-  find_library(ROCM_RUNTIME_LIBRARY amdhip64
-               PATHS "${HIP_PATH}/lib")
-  if (NOT ROCM_RUNTIME_LIBRARY)
-    message(SEND_ERROR "Could not locate ROCm HIP runtime library")
-  else()
-    message(STATUS "ROCm HIP runtime lib: ${ROCM_RUNTIME_LIBRARY}")
-  endif()
+  list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH} "${ROCM_PATH}/hip")
+  find_package(hip REQUIRED)
 
   if (NOT DEFINED ROCM_TEST_CHIPSET)
     execute_process(COMMAND "${ROCM_PATH}/bin/rocm_agent_enumerator"
     OUTPUT_VARIABLE AGENTS_STRING
     ERROR_VARIABLE AGENTS_STRING
     RESULT_VARIABLE AGENT_ENUMERATOR_RESULT)
 
     if (NOT AGENT_ENUMERATOR_RESULT EQUAL 0)
       message(SEND_ERROR "Could not run rocm_agent_enumerator and ROCM_TEST_CHIPSET is not defined")
       set(AGENTS_STRING "")
     endif()
if(MLIR_ENABLE_ROCM_RUNNER)
   endif()
   check_cxx_compiler_flag(-Wno-gnu-anonymous-struct
     CXX_SUPPORTS_WNO_GNU_ANONYMOUS_STRUCT_FLAG)
   if (CXX_SUPPORTS_WNO_GNU_ANONYMOUS_STRUCT_FLAG)
     target_compile_options(mlir_rocm_runtime PRIVATE
      "-Wno-gnu-anonymous-struct")
   endif()
 
-  target_compile_definitions(mlir_rocm_runtime
-    PRIVATE
-    __HIP_PLATFORM_HCC__
-  )
-  target_include_directories(mlir_rocm_runtime
-    PRIVATE
-    ${HIP_PATH}/include
-    ${ROCM_PATH}/include
-  )
   set_property(TARGET mlir_rocm_runtime
     PROPERTY INSTALL_RPATH_USE_LINK_PATH ON)
 
   target_link_libraries(mlir_rocm_runtime
     PUBLIC
-    ${ROCM_RUNTIME_LIBRARY}
+    hip::host hip::amdhip64
   )
 endif()