This is an archive of the discontinued LLVM Phabricator instance.

Differential D134698

[WIP][msan] Use !noundef of load instruction
Needs ReviewPublic

Authored by vitalybuka on Sep 26 2022, 9:28 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None

Diff Detail

Event Timeline

vitalybuka created this revision.Sep 26 2022, 9:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 26 2022, 9:28 PM
Herald added subscribers: Enna1, hiraditya. · View Herald Transcript
vitalybuka requested review of this revision.Sep 26 2022, 9:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 26 2022, 9:28 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
vitalybuka retitled this revision from Hook D134410 into msan to [WIP] Hook D134410 into msan.Sep 26 2022, 9:29 PM
vitalybuka added a parent revision: D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary 1 or 5).
vitalybuka retitled this revision from [WIP] Hook D134410 into msan to [WIP][msan] Use !noundef of load instruction.
Harbormaster completed remote builds in B188842: Diff 463087.Sep 26 2022, 10:10 PM
vitalybuka mentioned this in D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary 1 or 5).Sep 26 2022, 11:39 PM
vitalybuka updated this revision to Diff 468031.Oct 15 2022, 1:02 PM

fixes

Harbormaster completed remote builds in B192362: Diff 468031.Oct 15 2022, 2:48 PM

Revision Contents

PathSize
llvm/
lib/
Transforms/
Instrumentation/
10 lines

Diff 463087

llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp

Show First 20 Lines • Show All 2,131 Lines • ▼ Show 20 Lines void visitLoadInst(LoadInst &I) {
NextNodeIRBuilder IRB(&I); NextNodeIRBuilder IRB(&I);
Type *ShadowTy = getShadowTy(&I); Type *ShadowTy = getShadowTy(&I);
Value *Addr = I.getPointerOperand(); Value *Addr = I.getPointerOperand();
Value *ShadowPtr = nullptr, *OriginPtr = nullptr; Value *ShadowPtr = nullptr, *OriginPtr = nullptr;
const Align Alignment = I.getAlign(); const Align Alignment = I.getAlign();
if (PropagateShadow) { if (PropagateShadow) {
std::tie(ShadowPtr, OriginPtr) = std::tie(ShadowPtr, OriginPtr) =
getShadowOriginPtr(Addr, IRB, ShadowTy, Alignment, /*isStore*/ false); getShadowOriginPtr(Addr, IRB, ShadowTy, Alignment, /*isStore*/ false);
setShadow(&I, if (I.getMetadata(LLVMContext::MD_noundef)) {
IRB.CreateAlignedLoad(ShadowTy, ShadowPtr, Alignment, "_msld")); insertShadowCheck(
IRB.CreateAlignedLoad(ShadowTy, ShadowPtr, Alignment, "_msld"), &I);
setShadow(&I, getCleanShadow(&I));
} else {
setShadow(
&I, IRB.CreateAlignedLoad(ShadowTy, ShadowPtr, Alignment, "_msld"));
}
} else { } else {
setShadow(&I, getCleanShadow(&I)); setShadow(&I, getCleanShadow(&I));
} }
if (ClCheckAccessAddress) if (ClCheckAccessAddress)
insertShadowCheck(I.getPointerOperand(), &I); insertShadowCheck(I.getPointerOperand(), &I);
if (I.isAtomic()) if (I.isAtomic())
▲ Show 20 Lines • Show All 3,608 Lines • Show Last 20 Lines