This is an archive of the discontinued LLVM Phabricator instance.

[MC][test] Update arm64-leaf-compact-unwind.s to use llvm-objdump
ClosedPublic

Authored by int3 on Sep 26 2022, 7:05 PM.

Details

Summary

This addresses the long-standing FIXME in the test. I would like to
update the test, and objdump's output is a lot more readable / editable
than readobj's.

Diff Detail

Event Timeline

int3 created this revision.Sep 26 2022, 7:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 26 2022, 7:05 PM
int3 requested review of this revision.Sep 26 2022, 7:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 26 2022, 7:05 PM
int3 added a subscriber: Restricted Project.Sep 26 2022, 7:18 PM
jhenderson resigned from this revision.Sep 26 2022, 11:21 PM

I'm afraid my Mach-O knowledge is too limited to be able to confidently state that we're not losing coverage by transitioning from one to the other. Sorry.

llvm/test/MC/AArch64/arm64-leaf-compact-unwind.s
7–23

Nit: if you're changing the comment character used, change it throughout the test, not just in part of the test.

MaskRay accepted this revision.Sep 27 2022, 9:35 AM

Is the relocation information useful? If yes, having a one-line representation like llvm-readelf for ELF may be useful.

[nfc]

For pure test changes, [test] is more common.

This revision is now accepted and ready to land.Sep 27 2022, 9:35 AM
int3 added a comment.Sep 27 2022, 10:02 AM

The relocations are being parsed as part of --unwind-info already (to determine which function each CU entry is associated with)

int3 retitled this revision from [MC][nfc] Update arm64-leaf-compact-unwind.s to use llvm-objdump to [MC][test] Update arm64-leaf-compact-unwind.s to use llvm-objdump.Sep 27 2022, 11:54 AM
This revision was automatically updated to reflect the committed changes.
int3 marked an inline comment as done.