This addresses the long-standing FIXME in the test. I would like to
update the test, and objdump's output is a lot more readable / editable
than readobj's.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
I'm afraid my Mach-O knowledge is too limited to be able to confidently state that we're not losing coverage by transitioning from one to the other. Sorry.
llvm/test/MC/AArch64/arm64-leaf-compact-unwind.s | ||
---|---|---|
7–23 | Nit: if you're changing the comment character used, change it throughout the test, not just in part of the test. |
Comment Actions
Is the relocation information useful? If yes, having a one-line representation like llvm-readelf for ELF may be useful.
[nfc]
For pure test changes, [test] is more common.
Comment Actions
The relocations are being parsed as part of --unwind-info already (to determine which function each CU entry is associated with)
Nit: if you're changing the comment character used, change it throughout the test, not just in part of the test.