I've left the getAggregateElement as a fast path for non-ConstantExprs
to avoid a call to getSplatValue in release builds.
Fixes PR57989.
Paths
| Differential D134670
[IR][InstCombine] Support scalable vector splats ConstantExprs in Constant::getUniqueInteger(). ClosedPublic Authored by craig.topper on Sep 26 2022, 1:18 PM.
Details Summary I've left the getAggregateElement as a fast path for non-ConstantExprs Fixes PR57989.
Diff Detail
Event TimelineComment Actions LGTM, but please add the fast path comment to the code too, so the explanation for this code structure is obvious. This revision is now accepted and ready to land.Sep 26 2022, 2:34 PM Closed by commit rG90b695d1f24c: [IR][InstCombine] Support scalable vector splats ConstantExprs in Constant… (authored by craig.topper). · Explain WhySep 26 2022, 2:58 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 463004 llvm/lib/IR/Constants.cpp
llvm/test/Transforms/InstCombine/select.ll
|
clang-format not found in user’s local PATH; not linting file.