Differential D134647
[AArch64] Correct v9.x-a Features Authored by lenary on Sep 26 2022, 8:21 AM.
Details
A change to D109517 during review stated it was disabling the crypto This patch re-adds those two extensions to the feature bitmaps for the
Diff Detail
Event TimelineComment Actions Do you know if this code is necessary: https://github.com/llvm/llvm-project/blob/53c3664f674cc2f33c8214f493c2c17ce9b4d466/clang/lib/Driver/ToolChains/Arch/AArch64.cpp#L483 ? It is related, and I noticed it recently in other reviews. Comment Actions That code may be why no test changes were needed. All the target parsing code is so cursed. I think the TargetParser change will affect other non-clang LLVM tools, whereas that code is clang-only. I'm going to do another check or two, to see how load-bearing the clang code is or whether i can remove it now. Comment Actions The clang code is definitely load-bearing! I'm juggling a few too many things today to work out exactly why - I think the reality is that these feature bitmaps are only used in AArch64 when you use -mcpu= with a cpu of that version, and are ignored if you use -march=. This is not at all obvious! I think quite a lot of us are fed up with AArch64TargetParser.def because of all these confusing corners. Comment Actions OK - thanks for checking. The changes here look like an improvement, even if we can't remove that other code quite yet. I'm hoping that as target attributes improve we can remove a lot of the code that is currently in the Driver. |