This is an archive of the discontinued LLVM Phabricator instance.

Differential D134510

[bazel] Be consistent and say we don't support libfpm everywhere
ClosedPublic

Authored by aeubanks on Sep 22 2022, 6:44 PM.

Details

Reviewers
ctetreau
courbet
Commits
rG0de7c15c88b0: [bazel] Be consistent and say we don't support libfpm everywhere
Summary

We're inconsistent about saying whether or not we support libfpm in the bazel build.

This should perhaps be configurable via a --config.

This allows the buildbots to see when llvm-exegesis-related breakages occur.

Diff Detail

Event Timeline

aeubanks created this revision.Sep 22 2022, 6:44 PM
Herald added a reviewer: ctetreau. · View Herald TranscriptSep 22 2022, 6:44 PM
Herald added a reviewer: ctetreau. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: mstojanovic. · View Herald Transcript
aeubanks requested review of this revision.Sep 22 2022, 6:44 PM
Harbormaster completed remote builds in B188324: Diff 462372.Sep 22 2022, 6:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 22 2022, 6:44 PM
Herald added subscribers: llvm-commits, courbet. · View Herald Transcript
aeubanks added a reviewer: courbet.Sep 22 2022, 6:45 PM

if we really care about this in the bazel build then I can look into making things work on the bots

courbet accepted this revision.Sep 23 2022, 12:37 AM

How do we handle other optional deps with bazel (e.g. z3 or things like this) ?

This revision is now accepted and ready to land.Sep 23 2022, 12:37 AM
aeubanks added a comment.Sep 23 2022, 9:20 AM
In D134510#3810897, @courbet wrote:

How do we handle other optional deps with bazel (e.g. z3 or things like this) ?

looks like we just disable them all

Closed by commit rG0de7c15c88b0: [bazel] Be consistent and say we don't support libfpm everywhere (authored by aeubanks). · Explain WhySep 23 2022, 9:28 AM
This revision was automatically updated to reflect the committed changes.
aeubanks added a commit: rG0de7c15c88b0: [bazel] Be consistent and say we don't support libfpm everywhere.
rupprecht mentioned this in D138470: [bazel] Restore libpfm as a conditional dependency for exegesis..Nov 21 2022, 7:36 PM
rupprecht mentioned this in rG4aa77690b98e: [bazel] Restore libpfm as a conditional dependency for exegesis..Dec 28 2022, 8:13 AM

Revision Contents

PathSize
utils/
bazel/
llvm-project-overlay/
llvm/
13 lines
unittests/
6 lines

Diff 462519

utils/bazel/llvm-project-overlay/llvm/BUILD.bazel

Show First 20 Lines • Show All 2,599 Lines • ▼ Show 20 Linescc_library(
] + [ ] + [
"tools/llvm-exegesis/lib/{}/*.cpp".format(t) "tools/llvm-exegesis/lib/{}/*.cpp".format(t)
for t in llvm_target_exegesis for t in llvm_target_exegesis
] + [ ] + [
"tools/llvm-exegesis/lib/{}/*.h".format(t) "tools/llvm-exegesis/lib/{}/*.h".format(t)
for t in llvm_target_exegesis for t in llvm_target_exegesis
]), ]),
hdrs = glob(["tools/llvm-exegesis/lib/*.h"]), hdrs = glob(["tools/llvm-exegesis/lib/*.h"]),
copts = llvm_copts + ["-DHAVE_LIBPFM=1"], copts = llvm_copts,
features = ["-header_modules"], features = ["-header_modules"],
strip_include_prefix = "tools/llvm-exegesis/lib", strip_include_prefix = "tools/llvm-exegesis/lib",
tags = [
"manual", # External dependency (libpfm4)
"nobuildkite", # TODO(chandlerc): Add support for fetching and building libpfm4 and enable this.
],
deps = [ deps = [
":AllTargetsAsmParsers", ":AllTargetsAsmParsers",
":AllTargetsCodeGens", ":AllTargetsCodeGens",
":CodeGen", ":CodeGen",
":Core", ":Core",
":ExecutionEngine", ":ExecutionEngine",
":MC", ":MC",
":MCDisassembler", ":MCDisassembler",
▲ Show 20 Lines • Show All 454 Lines • ▼ Show 20 Linescc_binary(
], ],
) )
cc_binary( cc_binary(
name = "llvm-exegesis", name = "llvm-exegesis",
srcs = [ srcs = [
"tools/llvm-exegesis/llvm-exegesis.cpp", "tools/llvm-exegesis/llvm-exegesis.cpp",
], ],
copts = llvm_copts + ["-DHAVE_LIBPFM=0"], copts = llvm_copts,
linkopts = ["-lpfm"],
stamp = 0, stamp = 0,
tags = [
"manual", # External dependency (libpfm4 through Exegesis)
"nobuildkite", # TODO(chandlerc): Enable when the library builds.
],
deps = [ deps = [
":AllTargetsAsmParsers", ":AllTargetsAsmParsers",
":AllTargetsCodeGens", ":AllTargetsCodeGens",
":AllTargetsDisassemblers", ":AllTargetsDisassemblers",
":Exegesis", ":Exegesis",
":MC", ":MC",
":MCParser", ":MCParser",
":Object", ":Object",
▲ Show 20 Lines • Show All 1,462 Lines • Show Last 20 Lines

utils/bazel/llvm-project-overlay/llvm/unittests/BUILD.bazel

Show First 20 Lines • Show All 692 Lines • ▼ Show 20 Lines srcs = glob(
"tools/llvm-exegesis/*.cpp", "tools/llvm-exegesis/*.cpp",
"tools/llvm-exegesis/X86/*.cpp", "tools/llvm-exegesis/X86/*.cpp",
"tools/llvm-exegesis/X86/*.h", "tools/llvm-exegesis/X86/*.h",
], ],
allow_empty = False, allow_empty = False,
) + [ ) + [
"tools/llvm-exegesis/Common/AssemblerUtils.h", "tools/llvm-exegesis/Common/AssemblerUtils.h",
], ],
copts = ["-DHAVE_LIBPFM=1"],
linkopts = ["-lpfm"],
tags = [
"manual", # External dependency (libpfm4)
"nobuildkite", # TODO(chandlerc): Add support for fetching and building libpfm4 and enable this.
],
deps = [ deps = [
"//llvm:AllTargetsCodeGens", "//llvm:AllTargetsCodeGens",
"//llvm:AllTargetsDisassemblers", "//llvm:AllTargetsDisassemblers",
"//llvm:Exegesis", "//llvm:Exegesis",
"//llvm:MC", "//llvm:MC",
"//llvm:MCDisassembler", "//llvm:MCDisassembler",
"//llvm:Support", "//llvm:Support",
"//llvm:TestingSupport", "//llvm:TestingSupport",
"//llvm:gtest", "//llvm:gtest",
"//llvm:gtest_main", "//llvm:gtest_main",
], ],
) )