This is an archive of the discontinued LLVM Phabricator instance.

Differential D134448

[mlir][vector] Fix test for vector-warp-distribute
ClosedPublic

Authored by christopherbate on Sep 22 2022, 9:14 AM.

Details

Reviewers
aartbik
nicolasvasilache
dcaballe
ThomasRaoux
Commits
rGcb3d0260f070: [mlir][vector] Fix test for vector-warp-distribute
Summary

Test does a "CHECK-NOT" against the function name when it should check
to ensure that the vector.warp_execute_on_lane_0 is removed.

Diff Detail

Event Timeline

christopherbate created this revision.Sep 22 2022, 9:14 AM
Herald added a reviewer: aartbik. · View Herald TranscriptSep 22 2022, 9:14 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: zero9178, bzcheeseman, ThomasRaoux and 20 others. · View Herald Transcript
christopherbate requested review of this revision.Sep 22 2022, 9:14 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptSep 22 2022, 9:14 AM
Herald added a reviewer: dcaballe. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B188192: Diff 462198.Sep 22 2022, 9:14 AM
christopherbate added a reviewer: ThomasRaoux.Sep 22 2022, 9:14 AM
ThomasRaoux accepted this revision.Sep 22 2022, 9:34 AM

Thanks :)

This revision is now accepted and ready to land.Sep 22 2022, 9:34 AM
Closed by commit rGcb3d0260f070: [mlir][vector] Fix test for vector-warp-distribute (authored by christopherbate). · Explain WhySep 22 2022, 9:51 AM
This revision was automatically updated to reflect the committed changes.
christopherbate added a commit: rGcb3d0260f070: [mlir][vector] Fix test for vector-warp-distribute.

Revision Contents

PathSize
mlir/
test/
Dialect/
Vector/
2 lines

Diff 462218

mlir/test/Dialect/Vector/vector-warp-distribute.mlir

Show First 20 Lines • Show All 631 Lines • ▼ Show 20 Lines
// ----- // -----
// CHECK-PROP: func @lane_dependent_warp_propagate_read // CHECK-PROP: func @lane_dependent_warp_propagate_read
// CHECK-PROP-SAME: %[[ID:.*]]: index // CHECK-PROP-SAME: %[[ID:.*]]: index
func.func @lane_dependent_warp_propagate_read( func.func @lane_dependent_warp_propagate_read(
%laneid: index, %src: memref<1x1024xf32>, %dest: memref<1x1024xf32>) { %laneid: index, %src: memref<1x1024xf32>, %dest: memref<1x1024xf32>) {
// CHECK-PROP-DAG: %[[C0:.*]] = arith.constant 0 : index // CHECK-PROP-DAG: %[[C0:.*]] = arith.constant 0 : index
// CHECK-PROP-NOT: lane_dependent_warp_propagate_read // CHECK-PROP-NOT: vector.warp_execute_on_lane_0
// CHECK-PROP-DAG: %[[R0:.*]] = vector.transfer_read %arg1[%[[C0]], %[[ID]]], %{{.*}} : memref<1x1024xf32>, vector<1x1xf32> // CHECK-PROP-DAG: %[[R0:.*]] = vector.transfer_read %arg1[%[[C0]], %[[ID]]], %{{.*}} : memref<1x1024xf32>, vector<1x1xf32>
// CHECK-PROP: vector.transfer_write %[[R0]], {{.*}} : vector<1x1xf32>, memref<1x1024xf32> // CHECK-PROP: vector.transfer_write %[[R0]], {{.*}} : vector<1x1xf32>, memref<1x1024xf32>
%c0 = arith.constant 0 : index %c0 = arith.constant 0 : index
%cst = arith.constant 0.000000e+00 : f32 %cst = arith.constant 0.000000e+00 : f32
%r = vector.warp_execute_on_lane_0(%laneid)[32] -> (vector<1x1xf32>) { %r = vector.warp_execute_on_lane_0(%laneid)[32] -> (vector<1x1xf32>) {
%2 = vector.transfer_read %src[%c0, %c0], %cst : memref<1x1024xf32>, vector<1x32xf32> %2 = vector.transfer_read %src[%c0, %c0], %cst : memref<1x1024xf32>, vector<1x32xf32>
vector.yield %2 : vector<1x32xf32> vector.yield %2 : vector<1x32xf32>
} }
▲ Show 20 Lines • Show All 129 Lines • Show Last 20 Lines