Details
- Reviewers
aartbik nicolasvasilache bixia
Diff Detail
- Repository
- rG LLVM Github Monorepo
- Build Status
Buildable 188205 Build 284378: arc lint + arc unit
Event Timeline
| mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp | ||
|---|---|---|
| 595–601 | This is currently copied form https://reviews.llvm.org/D134096, will be resolved after the parents revision is merged. | |
| mlir/test/Dialect/SparseTensor/sparse_concat_codegen.mlir | ||
| 38 | This (and following pointers and indices) will (hopefully) be eliminated after lowering. | |
| mlir/test/Dialect/SparseTensor/sparse_concat_codegen.mlir | ||
|---|---|---|
| 37 | Note that the hasInserter is not set here | |
| mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorRewriting.cpp | ||
|---|---|---|
| 113 | Unordered | |
| 121 | I think the n-2 level needs to be not-unique as wel (so NuNo ;-) and then the last one unique again (so No) | |
| 127 | how about 0? default native | |
| 303 | why not else if? We have a general rule on no if after return, but I think this case does not apply when there is a new if | |
| 322 | What is still missing here? Can we assert on that? | |
| 331 | unordered | |
| 335 | Nice! Very progressive lowering approach. Nicolas will be proud of you! | |
| 352 | period at end | |
| mlir/test/Dialect/SparseTensor/sparse_concat_codegen.mlir | ||
| 3 | empty line before decl, also, name this DCSR | |
| mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorRewriting.cpp | ||
|---|---|---|
| 303 | Okay, I just followed what clang-tidy suggested me (no else on return), I can revert it back. | |
| mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorRewriting.cpp | ||
|---|---|---|
| 121 | Yeah, make sense... Do you think n-1 level need to be ordered? Considering all the input tensors is ordered right now? | |
| 303 | per offline discussion, we will keep the change. | |
| mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp | ||
| 211 | Any reason that we iterate over output tensor as well here? | |
Unordered