[Sanitizer] Fixup for ca50840b5bc0

[yln]

@protze.joachim does this fix the error you see?

[lechenyu]

In D134389#3809331, @yln wrote:

@protze.joachim does this fix the error you see?

Hi, Julian,

In total there are two errors in this file. Apart from the invocation of removed function "MaybeReexec", this file also misses a header file "sanitizer_common/sanitizer_interface_internal.h".
I have attached the compiler's error message in the following section for your reference.

/llvm-project/compiler-rt/lib/tsan/rtl-old/tsan_rtl.cpp:212:12: warning: variable 'i' set but not used [-Wunused-but-set-variable]

for (int i = 0;
         ^

/llvm-project/compiler-rt/lib/tsan/rtl-old/tsan_rtl.cpp:419:3: error: use of undeclared identifier 'MaybeReexec'

MaybeReexec();
^

/llvm-project/compiler-rt/lib/tsan/rtl-old/tsan_rtl.cpp:437:3: error: use of undeclared identifier '__sanitizer_set_report_path'

__sanitizer_set_report_path(common_flags()->log_path);

[yln]

Add include

[yln]

H @lechenyu, thanks for helping out! :)

this file also misses a header file "sanitizer_common/sanitizer_interface_internal.h".

This probably means that rtl-old is unused / bit rotting in more than one way. AFAIK, I didn't add this dependency in D129157.

I still added the #include, but it probably means we should remove rtl-old sooner than later.

[yln]

@lechenyu: do you mind signing off on this?

[lechenyu]

In D134389#3840581, @yln wrote:

@lechenyu: do you mind signing off on this?

I am sorry I forget to send you the confirmation. I have tested this patch last week and it did fix the issue.

compiler-rt/lib/tsan/rtl-old/tsan_rtl.cpp

 // Main file (entry points) for the TSan run-time.
 //===----------------------------------------------------------------------===//
 
 #include "tsan_rtl.h"
 
 #include "sanitizer_common/sanitizer_atomic.h"
 #include "sanitizer_common/sanitizer_common.h"
 #include "sanitizer_common/sanitizer_file.h"
+#include "sanitizer_common/sanitizer_interface_internal.h"
 #include "sanitizer_common/sanitizer_libc.h"
 #include "sanitizer_common/sanitizer_placement_new.h"
 #include "sanitizer_common/sanitizer_stackdepot.h"
 #include "sanitizer_common/sanitizer_symbolizer.h"
 #include "tsan_defs.h"
 #include "tsan_interface.h"
 #include "tsan_mman.h"
 #include "tsan_platform.h"
void Initialize(ThreadState *thr) {
   CacheBinaryName();
   CheckASLR();
   InitializeFlags(&ctx->flags, options, env_name);
   AvoidCVE_2016_2143();
   __sanitizer::InitializePlatformEarly();
   __tsan::InitializePlatformEarly();
 
 #if !SANITIZER_GO
-  // Re-exec ourselves if we need to set additional env or command line args.
-  MaybeReexec();
-
   InitializeAllocator();
   ReplaceSystemMalloc();
 #endif
   if (common_flags()->detect_deadlocks)
     ctx->dd = DDetector::Create(flags());
   Processor *proc = ProcCreate();
   ProcWire(proc, thr);
   InitializeInterceptors();