Page MenuHomePhabricator
People lechenyu

lechenyu (Lechen Yu)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 26 2021, 10:28 AM (105 w, 1 d)

Recent Activity
View All

Oct 28 2022

lechenyu added a comment to D136952: [libomptarget] Fix a race condition in checkDeviceAndCtors.
In D136952#3893183, @tianshilei1992 wrote:
In D136952#3893157, @jhuber6 wrote:
In D136952#3893155, @tianshilei1992 wrote:

Once per device?

It just means that we'd need an array of std::once_flags for each device. It's not a huge barrier but not sure if it's that much more convenient.

Yeah, that's what I mean. I generally think std::once_flags is cleaner than this method. I'm fine using PendingGlobalsMtx here as we can't get rid of it anyway.

Oct 28 2022, 6:35 PM · Restricted Project, Restricted Project
lechenyu requested review of D136952: [libomptarget] Fix a race condition in checkDeviceAndCtors.
Oct 28 2022, 7:51 AM · Restricted Project, Restricted Project

Oct 6 2022

lechenyu added a comment to D134389: [Sanitizer] Fixup for ca50840b5bc0.
In D134389#3840581, @yln wrote:

@lechenyu: do you mind signing off on this?

Oct 6 2022, 11:04 AM · Restricted Project, Restricted Project

Sep 23 2022

lechenyu added a comment to D134389: [Sanitizer] Fixup for ca50840b5bc0.
In D134389#3809331, @yln wrote:

@protze.joachim does this fix the error you see?

Hi, Julian,

Sep 23 2022, 2:49 PM · Restricted Project, Restricted Project

Aug 5 2021

lechenyu updated the diff for D106976: [openmp] Initialize OMPT in libomptarget.

Fix format issues.

Aug 5 2021, 10:26 AM · Restricted Project

Aug 4 2021

lechenyu updated the diff for D106976: [openmp] Initialize OMPT in libomptarget.

Fix format issues

Aug 4 2021, 8:10 AM · Restricted Project
lechenyu updated the diff for D106975: [openmp] Update OMPT declaration and implementation in the runtime.

Fix format issues

Aug 4 2021, 8:09 AM · Restricted Project
lechenyu updated the diff for D99803: [openmp] Add OMPT initialization in libomptarget.

Remove the unnecessary variable "libomp_start_tool".

Aug 4 2021, 8:04 AM · Restricted Project

Jul 28 2021

lechenyu requested review of D106976: [openmp] Initialize OMPT in libomptarget.
Jul 28 2021, 10:23 AM · Restricted Project
lechenyu requested review of D106975: [openmp] Update OMPT declaration and implementation in the runtime.
Jul 28 2021, 10:18 AM · Restricted Project
lechenyu updated the diff for D99803: [openmp] Add OMPT initialization in libomptarget.
Jul 28 2021, 10:09 AM · Restricted Project

Jul 16 2021

lechenyu updated the diff for D99803: [openmp] Add OMPT initialization in libomptarget.

Remove redundant macro definitions in omp-tools.h.var and rebase to the llvm/main

Jul 16 2021, 9:16 AM · Restricted Project

Apr 16 2021

lechenyu added inline comments to D99803: [openmp] Add OMPT initialization in libomptarget.
Apr 16 2021, 5:46 PM · Restricted Project
lechenyu updated the diff for D99803: [openmp] Add OMPT initialization in libomptarget.

Remove an unnecessary conditional directive

Apr 16 2021, 5:43 PM · Restricted Project
lechenyu updated the diff for D99803: [openmp] Add OMPT initialization in libomptarget.
Update ompt initialization in libomptarget:
    1. Change the initialization function name to "libomp_start_tool"
    2. Libomptarget uses weak symbol rather than libdl to retrieve
       libomp_start_tool
    3. Libomp_start_tool only sets the bitmap, since libomptarget will
       delegate the callback invocation to libomp. Libomptarget no
       longer needs the addresses of OMPT callbacks and entry points
Apr 16 2021, 2:19 PM · Restricted Project

Apr 3 2021

lechenyu updated the diff for D99803: [openmp] Add OMPT initialization in libomptarget.

Run clang-format to fix warnings in code style

Apr 3 2021, 5:44 PM · Restricted Project

Apr 2 2021

lechenyu requested review of D99803: [openmp] Add OMPT initialization in libomptarget.
Apr 2 2021, 10:08 AM · Restricted Project